From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756079AbbFPHOR (ORCPT ); Tue, 16 Jun 2015 03:14:17 -0400 Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:53229 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbbFPHOL (ORCPT ); Tue, 16 Jun 2015 03:14:11 -0400 Message-ID: <1434438845.2069.46.camel@x220> Subject: Re: [PATCH 4/5] clk: qcom: Add A53 clock driver From: Paul Bolle To: Georgi Djakov Cc: sboyd@codeaurora.org, agross@codeaurora.org, mturquette@linaro.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Date: Tue, 16 Jun 2015 09:14:05 +0200 In-Reply-To: <557EF0EB.9040403@linaro.org> References: <1434098519-26406-1-git-send-email-georgi.djakov@linaro.org> <1434098519-26406-5-git-send-email-georgi.djakov@linaro.org> <1434376712.2069.5.camel@x220> <557EF0EB.9040403@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-06-15 at 18:36 +0300, Georgi Djakov wrote: > In general, it is not expected to unload it as this is for the > main CPU clock, but i will add a module_exit() call to make it > correct. It's not incorrect to not have a module_exit() call. But not having it means you can't (easily and cleanly) unload this module. Which is uncommon enough for me to inquire whether that was by design. Thanks, Paul Bolle