Re: [PATCH 3.4 051/172] netfilter: xt_socket: fix a stack corruption bug

Pablo Neira Ayuso
2015-06-16T10:18:42Z

On Tue, Jun 16, 2015 at 04:35:05PM +0800, lizf@kernel.org wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> 3.4.108-rc1 review patch. If anyone has any objections, please let me know.
>
> ------------------
>
>
> commit 78296c97ca1fd3b104f12e1f1fbc06c46635990b upstream.
>
> As soon as extract_icmp6_fields() returns, its local storage (automatic
> variables) is deallocated and can be overwritten.
>
> Lets add an additional parameter to make sure storage is valid long
> enough.
>
> While we are at it, adds some const qualifiers.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Fixes: b64c9256a9b76 ("tproxy: added IPv6 support to the socket match")
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> [lizf: Backported to 3.4: adjust context]
> Signed-off-by: Zefan Li <lizefan@huawei.com>

Thanks for backporting this for 3.4.

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>