Re: [PATCH 3.4 035/172] ALSA: hdspm - Constrain periods to 2 on older cards

Zefan Li
2015-06-18T03:18:35Z

>> @@ -6042,6 +6042,12 @@ static int snd_hdspm_capture_open(struct snd_pcm_substream *substream)
>> snd_pcm_hw_constraint_minmax(runtime,
>> SNDRV_PCM_HW_PARAM_PERIOD_SIZE,
>> 64, 8192);
>> + snd_pcm_hw_constraint_minmax(runtime,
>> + SNDRV_PCM_HW_PARAM_PERIODS,
>> + 2, 2);
>> + snd_pcm_hw_constraint_minmax(runtime,
>> + SNDRV_PCM_HW_PARAM_PERIODS,
>> + 2, 2);
>> break;
>> }
>
> This is not correct, those lines need to go to two different functions
> (snd_hdspm_playback_open and snd_hdspm_capture_open).
>
> Here is how the patch should look like:
>

Now fixed. Thanks for review the patch.