From: Joe Perches <joe@perches.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Julien Grall <julien.grall@citrix.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format
Date: Tue, 16 Jun 2015 15:09:10 -0700 [thread overview]
Message-ID: <1434492550.2689.8.camel@perches.com> (raw)
In-Reply-To: <5580821D.4080408@cogentembedded.com>
On Tue, 2015-06-16 at 23:07 +0300, Sergei Shtylyov wrote:
> On 06/16/2015 10:10 PM, Julien Grall wrote:
> > Append 0x to all %x in order to avoid while reading when there is other
> > decimal value in the log.
[]
> > @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct xenvif_queue *queue,
> > if (unlikely(queue->grant_tx_handle[pending_idx] !=
> > NETBACK_INVALID_HANDLE)) {
> > netdev_err(queue->vif->dev,
> > - "Trying to overwrite active handle! pending_idx: %x\n",
> > + "Trying to overwrite active handle! pending_idx: 0x%x\n",
>
> Using "%#x" is shorter ind does the same.
That's true, but it's also far less common.
$ git grep -E "%#[\*\d\.]*x" | wc -l
1419
$ git grep "0x%" | wc -l
29844
next prev parent reply other threads:[~2015-06-16 22:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 19:10 [PATCH v4 0/3] net/xen: Clean up Julien Grall
2015-06-16 19:10 ` [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall
2015-06-21 16:41 ` David Miller
2015-06-16 19:10 ` [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall
2015-06-21 16:41 ` David Miller
2015-06-16 19:10 ` [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Julien Grall
2015-06-16 20:07 ` Sergei Shtylyov
2015-06-16 22:09 ` Joe Perches [this message]
2015-06-16 22:29 ` Sergei Shtylyov
2015-06-16 23:55 ` Joe Perches
2015-06-17 8:54 ` Ian Campbell
2015-06-17 9:13 ` [Xen-devel] " Jan Beulich
2015-06-17 9:25 ` Ian Campbell
2015-06-17 9:30 ` Julien Grall
2015-06-17 9:37 ` Ian Campbell
2015-06-21 16:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434492550.2689.8.camel@perches.com \
--to=joe@perches.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox