From: Stephane Viau <sviau@codeaurora.org>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
robdclark@gmail.com, Stephane Viau <sviau@codeaurora.org>
Subject: [RFC 0/2] drm/msm: HDMI PHY rework for MSM8x94 support
Date: Tue, 16 Jun 2015 18:24:07 -0400 [thread overview]
Message-ID: <1434493449-10314-1-git-send-email-sviau@codeaurora.org> (raw)
The RFC concerns a code restructuring of the HDMI module, which mainly has two
purposes:
1. architectural
HDMI registers are divided in two parts: HDMI core and HDMI PHY. The HDMI Core
registers are common to all chipsets sharing the MDP version (MDP5 here). On
the other hand, HDMI PHY registers depend on the interface and process (28nm,
20nm, ...) being used for the same chipsets. Some chipsets (eg: msm8x94) don't
require us to access HDMI PHY registers.
>From a software architecture point of view, it would make sense that all HDMI
PHY registers should only be accessed by (PHY) hdmi_phy_*.c files, while all
HDMI Core registers are read/written by the (core) hdmi.c and hdmi_connector.c
files.
2. readability
Once we add msm8x94, which does not program HDMI PHY registers, it will be
easier to handle the HDMI core register programming because a hdmi_phy_*.c
file won't be created for this chipset. Instead of creating such a stub file
or some kind of workaround, it only makes sense to bring the HDMI core register
programming where it is supposed to be.
To summarize, this re-structuring is to improve the code architecture,
facilitate the introduction of msm8x94 support and won't change the current
functionality.
Stephane Viau (2):
[RFC] drm/msm/hdmi: remove ->reset() from HDMI PHY
drm/msm: Add support for msm8x94
drivers/gpu/drm/msm/hdmi/hdmi.c | 30 ++++++----
drivers/gpu/drm/msm/hdmi/hdmi.h | 1 -
drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 8 ++-
drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 94 +++++++++++++++++++++++++------
drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c | 52 -----------------
drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c | 32 -----------
drivers/gpu/drm/msm/hdmi/hdmi_phy_8x74.c | 57 -------------------
drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c | 73 +++++++++++++++++++++++-
drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 8 ++-
9 files changed, 179 insertions(+), 176 deletions(-)
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
next reply other threads:[~2015-06-16 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 22:24 Stephane Viau [this message]
2015-06-16 22:24 ` [RFC 1/2] [RFC] drm/msm/hdmi: remove ->reset() from HDMI PHY Stephane Viau
2015-06-16 22:24 ` [RFC 2/2] drm/msm: Add support for msm8x94 Stephane Viau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434493449-10314-1-git-send-email-sviau@codeaurora.org \
--to=sviau@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox