From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbbFRAuw (ORCPT ); Wed, 17 Jun 2015 20:50:52 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:32915 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbbFRAuo (ORCPT ); Wed, 17 Jun 2015 20:50:44 -0400 Message-ID: <1434588639.6621.2.camel@ingics.com> Subject: [PATCH] regulator: qcom_spmi: Fix calculating number of voltages From: Axel Lin To: Mark Brown Cc: Stephen Boyd , Liam Girdwood , "linux-kernel@vger.kernel.org" , Andy Gross Date: Thu, 18 Jun 2015 08:50:39 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org n /= range->step_uV + 1; is equivalent to n /= (range->step_uV + 1); which is wrong. Fix it. Signed-off-by: Axel Lin --- drivers/regulator/qcom_spmi-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 162b865..42a60b4 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -1108,7 +1108,7 @@ static void spmi_calculate_num_voltages(struct spmi_voltage_set_points *points) n = 0; if (range->set_point_max_uV) { n = range->set_point_max_uV - range->set_point_min_uV; - n /= range->step_uV + 1; + n = (n / range->step_uV) + 1; } range->n_voltages = n; points->n_voltages += n; -- 2.1.0