From: Brian Norris <computersforpeace@gmail.com>
To: Kevin Cernekee <cernekee@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>
Cc: <bcm-kernel-feedback-list@broadcom.com>,
Brian Norris <computersforpeace@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
<linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] irqchip: bcm7120-l2: use of_io_request_and_map() to claim iomem
Date: Thu, 18 Jun 2015 16:05:25 -0700 [thread overview]
Message-ID: <1434668725-24058-1-git-send-email-computersforpeace@gmail.com> (raw)
This way, the IO resources will show up in /proc/iomem, and we can make
sure no other drivers are trying to claim these register regions.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
drivers/irqchip/irq-bcm7120-l2.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
index 3ba5cc780fcb..299d4de2deb5 100644
--- a/drivers/irqchip/irq-bcm7120-l2.c
+++ b/drivers/irqchip/irq-bcm7120-l2.c
@@ -142,10 +142,10 @@ static int __init bcm7120_l2_intc_iomap_7120(struct device_node *dn,
{
int ret;
- data->map_base[0] = of_iomap(dn, 0);
- if (!data->map_base[0]) {
+ data->map_base[0] = of_io_request_and_map(dn, 0, dn->full_name);
+ if (IS_ERR(data->map_base[0])) {
pr_err("unable to map registers\n");
- return -ENOMEM;
+ return PTR_ERR(data->map_base[0]);
}
data->pair_base[0] = data->map_base[0];
@@ -178,16 +178,17 @@ static int __init bcm7120_l2_intc_iomap_3380(struct device_node *dn,
for (gc_idx = 0; gc_idx < MAX_WORDS; gc_idx++) {
unsigned int map_idx = gc_idx * 2;
- void __iomem *en = of_iomap(dn, map_idx + 0);
- void __iomem *stat = of_iomap(dn, map_idx + 1);
- void __iomem *base = min(en, stat);
+ void __iomem *en, *stat, *base;
+
+ en = of_io_request_and_map(dn, map_idx + 0, "irq-en");
+ stat = of_io_request_and_map(dn, map_idx + 1, "irq-stat");
+ if (IS_ERR(en) || IS_ERR(stat))
+ break;
+ base = min(en, stat);
data->map_base[map_idx + 0] = en;
data->map_base[map_idx + 1] = stat;
- if (!base)
- break;
-
data->pair_base[gc_idx] = base;
data->en_offset[gc_idx] = en - base;
data->stat_offset[gc_idx] = stat - base;
--
1.9.1
next reply other threads:[~2015-06-18 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 23:05 Brian Norris [this message]
2015-06-26 20:51 ` [PATCH] irqchip: bcm7120-l2: use of_io_request_and_map() to claim iomem Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434668725-24058-1-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cernekee@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox