get-maintainer.pl \C gives perl indigestion...

get-maintainer.pl \C gives perl indigestion...

[Valdis Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

Fedora Rawhide upgraded from Perl 5.20 to 5.22, and is now whinging about stuff:

I'd supply a patch, but I'm unsure why \C is being used instead of a '.' -
presumably the "Break a UTF-8 character into pieces" semantic is desired here.

%  scripts/get_maintainer.pl -f scripts/get_maintainer.pl
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 307.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 552.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 570.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 619.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 634.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 935.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 949.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 963.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 989.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 1048.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 1090.
\C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 1107.
Joe Perches <joe@perches.com> (maintainer:GET_MAINTAINER SC...)
linux-kernel@vger.kernel.org (open list)

% rpm -q perl
perl-5.22.0-344.fc23.x86_64

% perl -v

This is perl 5, version 22, subversion 0 (v5.22.0) built for x86_64-linux-thread-multi
(with 12 registered patches, see perl -V for more detail)


[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

Re: get-maintainer.pl \C gives perl indigestion...

[Joe Perches]

On Thu, 2015-06-18 at 17:33 -0400, Valdis Kletnieks wrote:
> Fedora Rawhide upgraded from Perl 5.20 to 5.22, and is now whinging about stuff:
> 
> I'd supply a patch, but I'm unsure why \C is being used instead of a '.' -
> presumably the "Break a UTF-8 character into pieces" semantic is desired here.

Not really, any upper case char should do.
[A-Z] should be fine..

> %  scripts/get_maintainer.pl -f scripts/get_maintainer.pl
> \C is deprecated in regex; marked by <-- HERE in m/^(\C <-- HERE ):\s*(.*)/ at scripts/get_maintainer.pl line 307.
[]
> % perl -v
> This is perl 5, version 22, subversion 0 (v5.22.0) built for x86_64-linux-thread-multi
> (with 12 registered patches, see perl -V for more detail)

This should work.
Could you let me know if it works for you?
---
 scripts/get_maintainer.pl | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index fc169fd..8b3b0ca 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -304,7 +304,7 @@ open (my $maint, '<', "${lk_path}MAINTAINERS")
 while (<$maint>) {
     my $line = $_;
 
-    if ($line =~ m/^(\C):\s*(.*)/) {
+    if ($line =~ m/^([A-Z]):\s*(.*)/) {
 	my $type = $1;
 	my $value = $2;
 
@@ -549,7 +549,7 @@ sub range_is_maintained {
 
     for (my $i = $start; $i < $end; $i++) {
 	my $line = $typevalue[$i];
-	if ($line =~ m/^(\C):\s*(.*)/) {
+	if ($line =~ m/^([A-Z]):\s*(.*)/) {
 	    my $type = $1;
 	    my $value = $2;
 	    if ($type eq 'S') {
@@ -567,7 +567,7 @@ sub range_has_maintainer {
 
     for (my $i = $start; $i < $end; $i++) {
 	my $line = $typevalue[$i];
-	if ($line =~ m/^(\C):\s*(.*)/) {
+	if ($line =~ m/^([A-Z]):\s*(.*)/) {
 	    my $type = $1;
 	    my $value = $2;
 	    if ($type eq 'M') {
@@ -616,7 +616,7 @@ sub get_maintainers {
 
 	    for ($i = $start; $i < $end; $i++) {
 		my $line = $typevalue[$i];
-		if ($line =~ m/^(\C):\s*(.*)/) {
+		if ($line =~ m/^([A-Z]):\s*(.*)/) {
 		    my $type = $1;
 		    my $value = $2;
 		    if ($type eq 'X') {
@@ -631,7 +631,7 @@ sub get_maintainers {
 	    if (!$exclude) {
 		for ($i = $start; $i < $end; $i++) {
 		    my $line = $typevalue[$i];
-		    if ($line =~ m/^(\C):\s*(.*)/) {
+		    if ($line =~ m/^([A-Z]):\s*(.*)/) {
 			my $type = $1;
 			my $value = $2;
 			if ($type eq 'F') {
@@ -932,7 +932,7 @@ sub find_first_section {
 
     while ($index < @typevalue) {
 	my $tv = $typevalue[$index];
-	if (($tv =~ m/^(\C):\s*(.*)/)) {
+	if (($tv =~ m/^([A-Z]):\s*(.*)/)) {
 	    last;
 	}
 	$index++;
@@ -946,7 +946,7 @@ sub find_starting_index {
 
     while ($index > 0) {
 	my $tv = $typevalue[$index];
-	if (!($tv =~ m/^(\C):\s*(.*)/)) {
+	if (!($tv =~ m/^([A-Z]):\s*(.*)/)) {
 	    last;
 	}
 	$index--;
@@ -960,7 +960,7 @@ sub find_ending_index {
 
     while ($index < @typevalue) {
 	my $tv = $typevalue[$index];
-	if (!($tv =~ m/^(\C):\s*(.*)/)) {
+	if (!($tv =~ m/^([A-Z]):\s*(.*)/)) {
 	    last;
 	}
 	$index++;
@@ -986,7 +986,7 @@ sub get_maintainer_role {
 
     for ($i = $start + 1; $i < $end; $i++) {
 	my $tv = $typevalue[$i];
-	if ($tv =~ m/^(\C):\s*(.*)/) {
+	if ($tv =~ m/^([A-Z]):\s*(.*)/) {
 	    my $ptype = $1;
 	    my $pvalue = $2;
 	    if ($ptype eq "S") {
@@ -1045,7 +1045,7 @@ sub add_categories {
 
     for ($i = $start + 1; $i < $end; $i++) {
 	my $tv = $typevalue[$i];
-	if ($tv =~ m/^(\C):\s*(.*)/) {
+	if ($tv =~ m/^([A-Z]):\s*(.*)/) {
 	    my $ptype = $1;
 	    my $pvalue = $2;
 	    if ($ptype eq "L") {
@@ -1087,7 +1087,7 @@ sub add_categories {
 		if ($name eq "") {
 		    if ($i > 0) {
 			my $tv = $typevalue[$i - 1];
-			if ($tv =~ m/^(\C):\s*(.*)/) {
+			if ($tv =~ m/^([A-Z]):\s*(.*)/) {
 			    if ($1 eq "P") {
 				$name = $2;
 				$pvalue = format_email($name, $address, $email_usename);
@@ -1104,7 +1104,7 @@ sub add_categories {
 		if ($name eq "") {
 		    if ($i > 0) {
 			my $tv = $typevalue[$i - 1];
-			if ($tv =~ m/^(\C):\s*(.*)/) {
+			if ($tv =~ m/^([A-Z]):\s*(.*)/) {
 			    if ($1 eq "P") {
 				$name = $2;
 				$pvalue = format_email($name, $address, $email_usename);

Re: get-maintainer.pl \C gives perl indigestion...

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Thu, 18 Jun 2015 16:46:14 -0700, Joe Perches said:
> On Thu, 2015-06-18 at 17:33 -0400, Valdis Kletnieks wrote:
> > Fedora Rawhide upgraded from Perl 5.20 to 5.22, and is now whinging about s
tuff:
> >
> > I'd supply a patch, but I'm unsure why \C is being used instead of a '.' -
> > presumably the "Break a UTF-8 character into pieces" semantic is desired he
re.
>
> Not really, any upper case char should do.
> [A-Z] should be fine..

% patch -p1 < /tmp/joe-patch
patching file scripts/get_maintainer.pl
% scripts/get_maintainer.pl -f scripts/get_maintainer.pl
Joe Perches <joe@perches.com> (maintainer:GET_MAINTAINER SC...)
linux-kernel@vger.kernel.org (open list)

Looks OK to me.  Feel free to stick my Tested-By: on it. :)

[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]