From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbbFVDKZ (ORCPT ); Sun, 21 Jun 2015 23:10:25 -0400 Received: from mail-bn1bon0063.outbound.protection.outlook.com ([157.56.111.63]:52096 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751326AbbFVDKO convert rfc822-to-8bit (ORCPT ); Sun, 21 Jun 2015 23:10:14 -0400 X-Greylist: delayed 3604 seconds by postgrey-1.27 at vger.kernel.org; Sun, 21 Jun 2015 23:10:14 EDT Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; socionext.com; dkim=none (message not signed) header.d=none; Message-ID: <1434936985.20199.8.camel@ubuntu> Subject: Re: [PATCH 2/2] gpio: altera: fix return value of altera_gpio_remove() From: Tien Hock Loh To: Alexandre Courbot CC: Masahiro Yamada , "linux-gpio@vger.kernel.org" , Linus Walleij , Linux Kernel Mailing List Date: Sun, 21 Jun 2015 18:36:25 -0700 In-Reply-To: References: <1434542383-21314-1-git-send-email-yamada.masahiro@socionext.com> <1434542383-21314-2-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD045;1:ifn7DQnwEQOKoAgBkbJe1u07PAW9nnsuphsg3xBiBoF+Bs6qDi8O0ea0do2iut3qJmjFOecawwmvDix39B1C2EHz5fpRfxVmmtDqubH2caCqYsNM521hTztwnyqqux1xrxgp3zNeGUdZ5KYk8LWEirZkD0zh8FTom86+pOvZd7b4af6k0x6tzwGxWZYi6iTRLb+slM+ClU9Zh83+W1PcpF/gHeL/SIumzSoLH19ZmyRqju+CTJJxkkuvco79bDU2R9/uaXj2XqHjinGTYy8BFrLKQhn0GZpFjfqluh4M8giTy+wsbszdIc44aX1fiyp206cSNjGSvymgT6mjGJljVg== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(199003)(24454002)(189002)(377454003)(377424004)(51704005)(103116003)(50466002)(19580405001)(19580395003)(33646002)(76176999)(106466001)(6806004)(5001960100002)(92566002)(110136002)(105596002)(2950100001)(50986999)(189998001)(77156002)(62966003)(50226001)(47776003)(1411001)(86362001)(87936001)(46102003)(5820100001)(42186005)(23676002)(33716001)(7099028)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB239;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:SoftFail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB239;2:U/zdkZ+SEEjGlO6VDIySSbdJshwtfBGgDiYb1PgXMT50mM0ZRD5UAZhrompxHGkg;3:w9kH6m4Oaop4czoklnqfNu4P+kaVCw24khDKKMlfhRKkcL5iU21e/Rek5NuLJfMMfLXSrfQBU4/s3cS5/B8eqaSqNQdWRaULtX1tso1OfVXObo0PQYH9VanPG2JiPsMXnuUm1hvonDQ6REJA8QfrR1Jmy4HsVth2xCWnHvwO+Yd6yzvA7u+4dl58ZaekOAyCcuAFjAuLYatHhyEdxTUgshUGbk+llph5vyw4bvkkOLk=;20:sJYH2HkbGS6vkYGeq9AJiBgJoAu7WPCWzDyCfxgS0f3c5m1zYuBBNygxGoBZJ8yQKGI/nBl6Hwlc8SGKlaTnnydbqNrg6LKt/UJJ/CyyYztkyL+mjasKw/wIrgyjofGz9o/Kg7ZfOzoy5hDCRuVcsmVneq56zyo6YzsZDlh580Y=;4:sUc2jaciDUxbNIJk5G6YhSgTTyVV2ulTwImx+OsawBUkgysEoVUN5/A6OQ3lQUyjAjlVx/KxjeNkY4qRJAc4X/DP9RYmlkhEO6Lqfzy0Cpeo51J7lR1di5q0o1tNSrYulkFfFoVaWtpDml3XGOWM/6WSya+MNUSbjLECvUdkbp7FVe5DfOhJvDPlU0xL4xT4eGlCfBYwYC5qYXcblAQg1gxTcWHS6cXl2T6htdJa2W/E1ThaQiL8hkKXHBAiRkjkk0+HjAslIPan5+d9ijOd1CYsXKKphmfQGuJsbUND27U= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB239; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY2PR03MB239;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB239; X-Forefront-PRVS: 06157D541C X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAzTUIyMzk7MjM6WE0xMUtyS0Z2d1d5c0xJVENpRU00cS9YdWh4?= =?utf-8?B?REJKOWp4WEhwRGN3cTZzN1dwOThvQXM0djdNNW5TdDM4RElHZnN0dzJvUUc2?= =?utf-8?B?SHh1Q2U2YUd6dFNOaUFJaGQvK3hQVkNiNHBpYjhHN1Zib3dhRTAxWHdzVFFP?= =?utf-8?B?ZXJycVduNWlhSmQvdWJlSjkxRGxEcHNhQ2N5SWpLZHl6MkVNVUdqeXhhYTJB?= =?utf-8?B?ZU9UN0MzZG9tWStVN1htQ2JzTkhIL3ZXSGlXa0hJQ1owYUpsa01hNW1ENFFw?= =?utf-8?B?YWZjZklFWDNON2Exbk5CMUsrNnVVc21ZajV5bGRoQThsR3dqNlBlOENsMWxW?= =?utf-8?B?RU9hcmRCanVLMlV1c3o2NitmUUkyR1dHaFhXQ3EzYlV0WTdTQWdyQWVrc1lI?= =?utf-8?B?NG1XdU1nMVE3ZFpvSmNWMXJrSkZSOGZJTDNEWnJqRGJrbHZrcVRSSDlROTNy?= =?utf-8?B?UUNOZ2lwVmZCNWRWeGFXeC93cDdNSkRRT1VNZGgrYlZ1WERkaU5TTDU2YXhj?= =?utf-8?B?WDhKdHNUYnVGbm5uVWNoRFA5RzJVQklaOWVXM2t5dXhkOENaWFFGenUvRzBs?= =?utf-8?B?UVYyR2l4ZGhPYjVPbWd3K3VnRlFGWGtFVm1McWFVNUJzbTJ6cHZVZTMwRFZL?= =?utf-8?B?SXZSalVrdENjdHIwRmxGSUFZK285ZVcxOWY2ckljQ2RUaWpqMzFOTitjdzRq?= =?utf-8?B?VDJkdmlzWWliME1uMEFpRXZVZkhnUDJBR042dXRFSjcrTzd1SDFjTEVGVjVz?= =?utf-8?B?R0xaUmhZd0ZZdzBTY0ZMWkltWlNkWjV1U2ZmZnVSdlo0L0pSOUpsMm5CaGdq?= =?utf-8?B?clB6d1paZEVuRVdDenRremNaalFJMTFkSlgrQUJhYWZjWTBtTjNOdGR6aVV4?= =?utf-8?B?TzJidUtzdGNGZ0NnWE90ajI4c1JvZkQ4dXZ0UVdYaTh6MFF6TTE3ZVFJL2lj?= =?utf-8?B?ZXppZXRLVjI3MXdtNHJLOXZwSGVkT2NCQWRIVjFPSjgveG4vMHBiZitvNFZj?= =?utf-8?B?WUx4bWlBemNFK0dJVjQrZ2QwOURibkhhQ0tHbTZnQ0ZSOGZ5NURyaWE5WURX?= =?utf-8?B?bnkvTE1pU1FBOXd4ZlVWOEllV3AxSEs4SDh4Wk5xNVV2VjNGZnE5dkRKSElW?= =?utf-8?B?TXNCOU9xcnN0dlRyME56ckw5czRaMVMzSEQ5YU1JTHV0cG5Vc0d5RTlpcFZE?= =?utf-8?B?M0lEdGtrcUZud0Q1K0hDU093R2hLbC8xWkJVc2c2WVNJVTA4ci9xOHhkb0dH?= =?utf-8?B?US9sZW41a2hTaUpjU1R4alluNFpXRm0wT2xPdDcwWFdOYlovTUFIREhCdytY?= =?utf-8?B?NlZZaEcwbG1ZZz09?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB239;5:Ea6Yqx0Yovc1FRi7nOZGRVKLNQQ/fCR78EurLmYtSK8TZDRnLTg7+hRc0isv8IPLrQ7GFQeum7vNqSjiDySTWck0HfACoz/lPgQscWyYYjcxwcsTzn/Z7TdrSND2ssvhFHj29hQK2TauCslc4INr3w==;24:BTNMe2kNCG1GKMkKbAFVA4BaIkutHEyzbRPzZVKTQOo/RqgVkjmpEf+vMY3Vk3bgmbkTz17G/GCiPY3vbTR38G9Ihnz3H0ymAkvoAWPzGBg=;20:Otshjb3E09DCxj/wWI1xkPQYGxXqUN9TWTOtURGS/CvXd9b3k5eCuuIBZ8uEuxbkuUODl+5jqIDB5LaU1mAXQM9m+iJQqTb34I18qCJCY24maM9zgu4QQvsai2mBMls8LpiTQJ8zsmPh+Q3+nNneuG/PwetKRKc1U18ic6QgkLE= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2015 01:36:47.5706 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB239 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry I was away from my mail for the past few weeks. This isn't intentional, should be a bug I overlook. The fix is correct. On Sun, 2015-06-21 at 16:25 +0900, Alexandre Courbot wrote: > On Wed, Jun 17, 2015 at 8:59 PM, Masahiro Yamada > wrote: > > The remove callback never succeeds, which seems odd. > > > > Signed-off-by: Masahiro Yamada > > --- > > > > I wonder why nobody has pointed this out before me. > > I am suspecting -EIO might be intentional. > > I hope some Altera guys will give me comments. > > > > > > drivers/gpio/gpio-altera.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c > > index c653c83..5861550 100644 > > --- a/drivers/gpio/gpio-altera.c > > +++ b/drivers/gpio/gpio-altera.c > > @@ -339,7 +339,7 @@ static int altera_gpio_remove(struct platform_device *pdev) > > > > of_mm_gpiochip_remove(&altera_gc->mmchip); > > > > - return -EIO; > > + return 0; > > That looks weird indeed. Tien, can you comment on this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/