From: Joe Perches <joe@perches.com>
To: "Horacio Mijail Antón Quiles" <hmijail@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Howells <dhowells@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH v2] hexdump: fix for non-aligned buffers
Date: Sun, 21 Jun 2015 21:58:03 -0700 [thread overview]
Message-ID: <1434949083.9808.8.camel@perches.com> (raw)
In-Reply-To: <20150621234234.GA24689@mija-VirtualBox>
On Mon, 2015-06-22 at 01:42 +0200,
=?UTF-8?q?Horacio=20Mijail=20Ant=C3=B3n=20Quiles?= wrote:
> An hexdump with a buf not aligned to the groupsize causes
> non-naturally-aligned memory accesses. This was causing a kernel panic on
> the processor BlackFin BF527, when such an unaligned buffer was fed by the
> function ubifs_scanned_corruption in fs/ubifs/scan.c .
[]
> diff --git a/lib/hexdump.c b/lib/hexdump.c
[]
> @@ -123,6 +123,11 @@ int hex_dump_to_buffer(const void *buf, size_t len, int rowsize, int groupsize,
> groupsize = 1;
> if ((len % groupsize) != 0) /* no mixed size output */
> groupsize = 1;
> +
> + /* fall back to 1-byte groups if buf is not aligned to groupsize*/
Please add a space before the "*/"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2015-06-22 4:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 23:42 [PATCH v2] hexdump: fix for non-aligned buffers =?UTF-8?q?Horacio=20Mijail=20Ant=C3=B3n=20Quiles?=
2015-06-22 4:58 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434949083.9808.8.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=hmijail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox