Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

Alexey Brodkin
2015-06-24T08:36:21Z

Hi David,

On Wed, 2015-06-24 at 01:44 -0700, David Miller wrote:
> From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Date: Wed, 24 Jun 2015 11:07:26 +0300
>
> >
> > - priv->dma_tx = dma_alloc_coherent(priv->device,
> > txsize *
> > + priv->dma_tx = dma_zalloc_coherent(priv->device,
> > txsize *
> > sizeof(struct
> > dma_desc),
> > &priv
> > ->dma_tx_phy,
> > GFP_KERNEL);
>
> When you change the column at which the openning parenthesis of the
> function call occurs, you must indent the subsequent lines of the
> function call such that the all are adjusted to properly start
> at the very next column after that openning parenthesis.'
>
> Please fix this up for all of the dma_zalloc_coherent()
> transformations.

I thought about that and actually made this change initially but later
reverted it because I noticed dma_free_coherent() had parameters not
-aligned/idented properly.

So do you think if I may fix identation of dma_free_coherent() while at
it as well or I need to send a separate patch that takes care about
dma_free_coherent() solely?

-Alexey