From: Paul Bolle <pebolle@tiscali.nl>
To: Tobias Diedrich <ranma+kernel@tdiedrich.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: Add AMD SB8XX/SB9XX/A5X/A8X driver
Date: Mon, 22 Jun 2015 10:48:46 +0200 [thread overview]
Message-ID: <1434962926.19497.88.camel@x220> (raw)
In-Reply-To: <20150620215753.GD29802@yumi.tdiedrich.de>
[Shouldn't gpio patches be sent to Linus Walleij, Alexandre Courbot, and
the linux-gpio list too?]
Just a nit: a license mismatch.
On Sat, 2015-06-20 at 23:57 +0200, Tobias Diedrich wrote:
> --- /dev/null
> +++ b/drivers/gpio/gpio-sb8xx.c
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think that either the comment at the top of this file
or the ident used in the MODULE_LICENSE() macro needs to change.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-22 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 21:57 [PATCH] gpio: Add AMD SB8XX/SB9XX/A5X/A8X driver Tobias Diedrich
2015-06-22 8:48 ` Paul Bolle [this message]
2015-07-17 11:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434962926.19497.88.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=ranma+kernel@tdiedrich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox