Re: [PATCH 17/17] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node

Roger Quadros
2015-06-24T12:03:31Z

On Wed, 24 Jun 2015 03:41:16 -0700
Tony Lindgren <tony@atomide.com> wrote:

> * Kishon Vijay Abraham I <kishon@ti.com> [150623 05:02]:
> > --- a/arch/arm/boot/dts/omap4.dtsi
> > +++ b/arch/arm/boot/dts/omap4.dtsi
> > @@ -852,12 +852,6 @@
> > };
> > };
> >
> > - omap_control_usbotg: control-phy@4a00233c {
> > - compatible = "ti,control-phy-otghs";
> > - reg = <0x4a00233c 0x4>;
> > - reg-names = "otghs_control";
> > - };
> > -
> > usb_otg_hs: usb_otg_hs@4a0ab000 {
> > compatible = "ti,omap4-musb";
> > reg = <0x4a0ab000 0x7ff>;
> > @@ -870,7 +864,7 @@
> > multipoint = <1>;
> > num-eps = <16>;
> > ram-bits = <12>;
> > - ctrl-module = <&omap_control_usbotg>;
> > + syscon-otghs = <&scm_conf 0x33c>;
> > };
> >
> > aes: aes@4b501000 {
>
> We should still keep a separate entry for the phy in the dtsi
> files. And the phy should be a child of the scm_conf area in the
> dtsi file.

The PHY already has a separate entry with its own set of registers.
Just that some bits have been shoved into the control module space
not only for PHY but for other modules as well like DSS, DCAN, etc.

>
> This is because the scm and usb_otg_hs are separate devices and
> can be clocked separately. So the phy driver needs to be a
> separate driver to avoid spaghetti code and issues with clocking.

for the PHY register space this is already done.

But for the register bits that lie in control module space isn't that
taken care by syscon driver?

cheers,
-roger