Re: [PATCH 08/17] ARM: dts: dra7: Add dt node for the sycon pcie

Roger Quadros
2015-06-24T12:20:36Z

On Wed, 24 Jun 2015 05:09:39 -0700
Tony Lindgren <tony@atomide.com> wrote:

> * Roger Quadros <rogerq@ti.com> [150624 04:58]:
> > On Wed, 24 Jun 2015 14:50:17 +0300
> > Roger Quadros <rogerq@ti.com> wrote:
> >
> > > On Tue, 23 Jun 2015 17:28:53 +0530
> > > Kishon Vijay Abraham I <kishon@ti.com> wrote:
> > >
> > > > Add new device tree node for the control module register space where
> > > > PCIe registers are present.
> > > >
> > > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > > > ---
> > > > arch/arm/boot/dts/dra7.dtsi | 5 +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> > > > index 260f300..3f434f7 100644
> > > > --- a/arch/arm/boot/dts/dra7.dtsi
> > > > +++ b/arch/arm/boot/dts/dra7.dtsi
> > > > @@ -291,6 +291,11 @@
> > > > reg = <0x4a002e00 0x7c>;
> > > > };
> > > >
> > > > + dra7_ctrl_pcie: tisyscon@4a003c00 {
> > > > + compatible = "syscon";
> > > > + reg = <0x4a003c00 0x48>;
> > > > + };
> > > > +
> > >
> > > Why do you need to start from 0x4a003c00?
> > > CTRL_CORE_PCIESS1_PCS1 is at 0x4a003c24
> >
> > Also, why can't this dra7_ctrl_pcie node be where scm_conf is.
>
> Yes all the scm children should be under scm@2000 entry in the
> dra7.dtsi file.
>
> And BTW, there's nothing stopping a driver doing of_ioremap
> on a larger range and be a child under scm@2000 in the dra7.dtsi
> if that range is dedicated to a single driver.

Agreed.

>
> My take is we should only use regmap for the scm_conf area
> in general.

+1

should we get rid of dra7_ctrl_core and dra7_ctrl_general?
or move them to scm node?

cheers,
-roger