From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933638AbbFXAHc (ORCPT ); Tue, 23 Jun 2015 20:07:32 -0400 Received: from smtprelay0110.hostedemail.com ([216.40.44.110]:37180 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932669AbbFXAH2 (ORCPT ); Tue, 23 Jun 2015 20:07:28 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2198:2199:2200:2393:2559:2562:2731:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3873:4321:5007:6261:7901:10004:10400:10471:10848:11026:11232:11473:11658:11914:12043:12114:12438:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: lunch51_40d7cf079b728 X-Filterd-Recvd-Size: 1982 Message-ID: <1435104444.2504.28.camel@perches.com> Subject: Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma_one From: Joe Perches To: Kuninori Morimoto Cc: ulf.hansson@linaro.org, Nicholas Krause , ben.dooks@codethink.co.uk, ykaneko0929@gmail.com, laurent.pinchart+renesas@ideasonboard.com, kouichi.tomita.yn@renesas.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 23 Jun 2015 17:07:24 -0700 In-Reply-To: <87r3p2rnek.wl%kuninori.morimoto.gx@renesas.com> References: <1431366550-22045-1-git-send-email-xerofoify@gmail.com> <87r3p2rnek.wl%kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-06-24 at 08:54 +0900, Kuninori Morimoto wrote: > Can you please teach us about status of this patch ? > > This adds a cast to the variables,slave_id_rx and slave_id_rx > > to uintptr_t before casting to void* in order to avoid build > > warning on 64bit platforms for the function, sh_mmcif_request_dma_one. [] > > diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c [] > > @@ -398,8 +398,8 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host, > > > > if (pdata) > > slave_data = direction == DMA_MEM_TO_DEV ? > > - (void *)pdata->slave_id_tx : > > - (void *)pdata->slave_id_rx; > > + (void *)(uintptr_t)pdata->slave_id_tx : > > + (void *)(uintptr_t)pdata->slave_id_rx; It's far more common (~10:1) in the kernel to cast using ( *)(unsigned long) than ( *)(uintptr_t)