Re: [PATCH] i2c: designware: use enable on resume instead initialization

Mika Westerberg
2015-06-24T11:29:44Z

On Wed, Jun 24, 2015 at 09:36:43AM +0200, christian.ruppert@alitech.com wrote:
> Dear Lucas,
>
> Lucas De Marchi <lucas.de.marchi@gmail.com> wrote on 23.06.2015 19:02:03:
> > On Tue, Jun 23, 2015 at 1:45 PM, <christian.ruppert@alitech.com> wrote:
> > > Hello,
> > >
> > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
> > [...]
> > > The result is not very encouraging: Out of five (identical) designware
> i2c
> > > controllers we have on my test SOC, the first one initialises properly
> but
> > > the second one gets stuck in the famous irq loop right away when the
> > > module is enabled in i2c_dw_init. The system never gets around to try
> >
> > Are you using the pci or platform driver? I noticed yesterday the pci
> > version is failing here with a NULL pointer dereference.
>
> The test was performed with the platform driver (instantiated through
> device tree).
> I just re-checked and the ultimate problem which hangs/kills the system in
> my case is the IRQ loop.
> I haven't observed any NULL pointer dereferences on the road.

Thanks Christian for testing.

Since the patch causes problems on your hardware, I don't think it is
good idea to merge it.