From: Constantine Shulyupin <const@MakeLinux.com>
To: jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Cc: const <const@MakeLinux.com>, Constantine Shulyupin <const@MakeLinux.com>
Subject: [PATCH] fix nct7802_temp_is_visible
Date: Thu, 25 Jun 2015 01:47:31 +0300 [thread overview]
Message-ID: <1435186051-10196-1-git-send-email-const@MakeLinux.com> (raw)
From: const <const@makelinux.com>
Fixed registers are invisible only when registers' mode is 0
Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
---
drivers/hwmon/nct7802.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
index ec56782..65e40c2 100644
--- a/drivers/hwmon/nct7802.c
+++ b/drivers/hwmon/nct7802.c
@@ -541,13 +541,11 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj,
if (err < 0)
return 0;
- if (index < 9 &&
- (reg & 03) != 0x01 && (reg & 0x03) != 0x02) /* RD1 */
+ if (index < 9 && !(reg & 0x03)) /* RD1 */
return 0;
- if (index >= 9 && index < 18 &&
- (reg & 0x0c) != 0x04 && (reg & 0x0c) != 0x08) /* RD2 */
+ if (index >= 9 && index < 18 && !(reg & 0x0c)) /* RD2 */
return 0;
- if (index >= 18 && index < 27 && (reg & 0x30) != 0x10) /* RD3 */
+ if (index >= 18 && index < 27 && !(reg & 0x30)) /* RD3 */
return 0;
if (index >= 27 && index < 35) /* local */
return attr->mode;
--
1.9.1
next reply other threads:[~2015-06-24 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 22:47 Constantine Shulyupin [this message]
2015-06-25 0:00 ` [PATCH] fix nct7802_temp_is_visible Guenter Roeck
[not found] ` <CAE7jHC95bpZfqDyFOsh-Do3vvrsVDcWVEpSicLx5arzS9c6qKg@mail.gmail.com>
2015-06-25 17:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435186051-10196-1-git-send-email-const@MakeLinux.com \
--to=const@makelinux.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox