Re: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner.

Peter Griffin
2015-07-30T09:47:48Z

Hi Mauro / Joe,

On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:

> Em Wed, 24 Jun 2015 18:17:37 -0700
> Joe Perches <joe@perches.com> escreveu:
>
> > On Wed, 2015-06-24 at 16:11 +0100, Peter Griffin wrote:
> > > This is used in conjunction with the STV0367 demodulator on
> > > the STV0367-NIM-V1.0 NIM card which can be used with the STi
> > > STB SoC's.
> >
> > Barely associated to this specific patch, but for
> > dvb-pll.c, another thing that seems possible is to
> > convert the struct dvb_pll_desc uses to const and
> > change the "entries" fixed array size from 12 to []
> >
> > It'd save a couple KB overall and remove ~5KB of data.
> >
> > $ size drivers/media/dvb-frontends/dvb-pll.o*
> > text data bss dec hex filename
> > 8520 1552 2120 12192 2fa0 drivers/media/dvb-frontends/dvb-pll.o.new
> > 5624 6363 2120 14107 371b drivers/media/dvb-frontends/dvb-pll.o.old
>
> Peter,
>
> Please add this patch on the next patch series you submit.

Ok will do, I've added this patch with a slightly updated commit message
to my series.

Joe - Can I add your signed-off-by?

regards,

Peter.