From: Joe Perches <joe@perches.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: linux-kernel@vger.kernel.org, Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>, Dean Lee <dean.lee@atmel.com>,
Chris Park <chris.park@atmel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 3/4] staging: wilc1000: remove whitespaces before quoted newlines
Date: Fri, 26 Jun 2015 07:49:32 -0700 [thread overview]
Message-ID: <1435330172.9377.52.camel@perches.com> (raw)
In-Reply-To: <20150626144555.GA30031@goodgumbo.baconseed.org>
On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
> Fix all checkpatch.pl warnings:
> WARNING: unnecessary whitespace before a quoted newline
Unassociated but:
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
[]
> @@ -740,7 +740,7 @@ s32 Handle_set_IPAddress(void *drvHandler, u8 *pu8IPAddr, u8 idx)
> if (pu8IPAddr[0] < 192)
> pu8IPAddr[0] = 0;
>
> - PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %d.%d.%d.%d \n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8IPAddr[2], pu8IPAddr[3]);
> + PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %d.%d.%d.%d\n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8IPAddr[2], pu8IPAddr[3]);
These printks with ip addresses could use vsprintf extension %pI4
PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %pI4\n",
idx, pu8IPAddr);
next prev parent reply other threads:[~2015-06-26 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 14:45 [PATCH 3/4] staging: wilc1000: remove whitespaces before quoted newlines Luis de Bethencourt
2015-06-26 14:49 ` Joe Perches [this message]
2015-06-26 15:11 ` Luis de Bethencourt
2015-06-26 15:16 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435330172.9377.52.camel@perches.com \
--to=joe@perches.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox