From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752404AbbF0ExR (ORCPT ); Sat, 27 Jun 2015 00:53:17 -0400 Received: from smtprelay0224.hostedemail.com ([216.40.44.224]:38662 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751672AbbF0ExI (ORCPT ); Sat, 27 Jun 2015 00:53:08 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:4321:5007:7514:7652:10004:10400:10848:11232:11657:11658:11914:12043:12517:12519:12555:12740:13069:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: crib99_725f786311663 X-Filterd-Recvd-Size: 2064 Message-ID: <1435380784.9377.69.camel@perches.com> Subject: Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c From: Joe Perches To: Vasiliy Korchagin Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 26 Jun 2015 21:53:04 -0700 In-Reply-To: <1435380294-22675-1-git-send-email-vasiliy.korchagin@gmail.com> References: <1435380294-22675-1-git-send-email-vasiliy.korchagin@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-06-27 at 05:44 +0100, Vasiliy Korchagin wrote: > This patch fixes the checkpatch.pl error: > > ERROR: Macros with complex values should be enclosed in parentheses > +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) > > Signed-off-by: Vasiliy Korchagin > --- > drivers/staging/lustre/lustre/obdclass/uuid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/uuid.c b/drivers/staging/lustre/lustre/obdclass/uuid.c > index ff0a01b..8d00882 100644 > --- a/drivers/staging/lustre/lustre/obdclass/uuid.c > +++ b/drivers/staging/lustre/lustre/obdclass/uuid.c > @@ -55,7 +55,7 @@ static inline __u32 consume(int nob, __u8 **ptr) > return value; > } > > -#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) > +#define CONSUME(val, ptr) ((val) = consume(sizeof(val), (ptr))) CONSUME is used exactly once. It'd be likely be simpler to remove it and expand it in-place instead. The static inline __u32 consume() function is also used once and might as well be expanded in-place too.