From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571AbbF1JBR (ORCPT ); Sun, 28 Jun 2015 05:01:17 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33686 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbbF1JBE (ORCPT ); Sun, 28 Jun 2015 05:01:04 -0400 Message-ID: <1435482057.28808.2.camel@ingics.com> Subject: [PATCH] nvdimm: Fix return value of nvdimm_bus_init() if class_create() fails From: Axel Lin To: Dan Williams Cc: Toshi Kani , Christoph Hellwig , linux-kernel@vger.kernel.org Date: Sun, 28 Jun 2015 17:00:57 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return proper error if class_create() fails. Signed-off-by: Axel Lin --- drivers/nvdimm/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index ca80270..f6f6a91 100644 --- a/drivers/nvdimm/bus.c +++ b/drivers/nvdimm/bus.c @@ -644,8 +644,10 @@ int __init nvdimm_bus_init(void) nvdimm_major = rc; nd_class = class_create(THIS_MODULE, "nd"); - if (IS_ERR(nd_class)) + if (IS_ERR(nd_class)) { + rc = PTR_ERR(nd_class); goto err_class; + } return 0; -- 2.1.0