From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953AbbF3IQh (ORCPT ); Tue, 30 Jun 2015 04:16:37 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:33260 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbbF3IQF (ORCPT ); Tue, 30 Jun 2015 04:16:05 -0400 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, jolsa@redhat.com, namhyung@kernel.org, Ingo Molnar , Taeung Song Subject: [PATCH 5/5] perf report: Fill in the missing freeing a session after an error occur Date: Tue, 30 Jun 2015 17:15:24 +0900 Message-Id: <1435652124-22414-6-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1435652124-22414-1-git-send-email-treeze.taeung@gmail.com> References: <1435652124-22414-1-git-send-email-treeze.taeung@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When an error occur a error value is just returned without freeing the session. So allocating and freeing session have to be matched as a pair even if an error occur. Signed-off-by: Taeung Song --- tools/perf/builtin-report.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 32626ea..610d056 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -828,8 +828,10 @@ repeat: if (report.header || report.header_only) { perf_session__fprintf_info(session, stdout, report.show_full_info); - if (report.header_only) - return 0; + if (report.header_only) { + ret = 0; + goto error; + } } else if (use_browser == 0) { fputs("# To display the perf.data header info, please use --header/--header-only options.\n#\n", stdout); -- 1.9.1