From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753500AbbF3Ngi (ORCPT ); Tue, 30 Jun 2015 09:36:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54365 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471AbbF3Ngb (ORCPT ); Tue, 30 Jun 2015 09:36:31 -0400 Message-ID: <1435671327.1726.1.camel@suse.com> Subject: Re: [PATCH] usb: move assignment out of if condition From: Oliver Neukum To: Kris Borer Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, balbi@ti.com, pmladek@suse.cz, antoine.tenart@free-electrons.com, hdegoede@redhat.com, sergei.shtylyov@cogentembedded.com, rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 30 Jun 2015 15:35:27 +0200 In-Reply-To: <1435669342-8333-1-git-send-email-kborer@gmail.com> References: <1435669342-8333-1-git-send-email-kborer@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-06-30 at 09:02 -0400, Kris Borer wrote: > Fix four occurrences of the checkpatch.pl error: > > ERROR: do not use assignment in if condition > > Signed-off-by: Kris Borer Sorry, but NACK! Those patches are totally broken. > --- > drivers/usb/core/hcd.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > index be5b207..e268c45 100644 > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c > @@ -2683,12 +2683,13 @@ int usb_add_hcd(struct usb_hcd *hcd, > * bottom up so that hcds can customize the root hubs before hub_wq > * starts talking to them. (Note, bus id is assigned early too.) > */ > - if ((retval = hcd_buffer_create(hcd)) != 0) { > + retval = hcd_buffer_create(hcd); > + if (retval != 0) { > dev_dbg(hcd->self.controller, "pool alloc failed\n"); > goto err_create_buf; > } > - > - if ((retval = usb_register_bus(&hcd->self)) < 0) > + retval = usb_register_bus(&hcd->self); > + if (retval < 0) > goto err_register_bus; > > rhdev = usb_alloc_dev(NULL, &hcd->self, 0); > @@ -2734,7 +2735,8 @@ int usb_add_hcd(struct usb_hcd *hcd, > /* "reset" is misnamed; its role is now one-time init. the controller > * should already have been reset (and boot firmware kicked off etc). > */ > - if (hcd->driver->reset && (retval = hcd->driver->reset(hcd)) < 0) { > + retval = hcd->driver->reset(hcd); You happily follow the NULL pointer. Regards Oliver