Re: [PATCH] scripts: checkpatch: ignore stable commit annotation

[Joe Perches <joe@perches.com>]

On Tue, 2015-06-30 at 17:07 -0500, Felipe Balbi wrote:
> When running scripts/checkpatch.pl on stable commits,
> we always get the error for not using 12-character
> commit hash abbreviation with shortlog within ("").

Looking at linux-stable v3.14.44 (randomly chosen), there
are also commit entries like:

   This is commit 0f540c3a7cfb91c9d7a19eb0c95c24 upstream.
 commit:  cb64edb6b89491edfdbae52ba7db9a8b8391d339 upstream

is -stable now using some script to tag these or is it
freehanded and happens to be reasonably consistent?

> Because that's actually a false positive, let's ignore
> stable commit annotation.

This will have to be respun against another patch:
https://lkml.org/lkml/2015/6/19/491

Please cc Andrew Morton if you resubmit.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2330,6 +2331,7 @@ sub process {
>  			my $orig_desc = "commit description";
>  			my $description = "";
>  
> +			$stable = 1 if ($line =~ /\bcommit\s+[0-9a-f]{40}\s+upstream\./i);

If these are really scripted, the case-insensitive /i
shouldn't be necessary.