From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753463AbbF3Wap (ORCPT <rfc822;w@1wt.eu>);
	Tue, 30 Jun 2015 18:30:45 -0400
Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:48335 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752416AbbF3Wai (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 30 Jun 2015 18:30:38 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:966:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2525:2560:2563:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3653:3865:3867:3868:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4385:5007:6261:7903:9025:10004:10400:10848:11232:11473:11658:11914:12043:12266:12438:12517:12519:12555:12679:12740:13069:13311:13357:13845:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: shelf44_3f7c9a9709f46
X-Filterd-Recvd-Size: 1945
Message-ID: <1435703435.12101.50.camel@perches.com>
Subject: Re: [PATCH] scripts: checkpatch: ignore stable commit annotation
From: Joe Perches <joe@perches.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Andy Whitcroft <apw@canonical.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date: Tue, 30 Jun 2015 15:30:35 -0700
In-Reply-To: <1435702063-12871-1-git-send-email-balbi@ti.com>
References: <1435702063-12871-1-git-send-email-balbi@ti.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2015-06-30 at 17:07 -0500, Felipe Balbi wrote:
> When running scripts/checkpatch.pl on stable commits,
> we always get the error for not using 12-character
> commit hash abbreviation with shortlog within ("").

Looking at linux-stable v3.14.44 (randomly chosen), there
are also commit entries like:

   This is commit 0f540c3a7cfb91c9d7a19eb0c95c24 upstream.
 commit:  cb64edb6b89491edfdbae52ba7db9a8b8391d339 upstream

is -stable now using some script to tag these or is it
freehanded and happens to be reasonably consistent?

> Because that's actually a false positive, let's ignore
> stable commit annotation.

This will have to be respun against another patch:
https://lkml.org/lkml/2015/6/19/491

Please cc Andrew Morton if you resubmit.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2330,6 +2331,7 @@ sub process {
>  			my $orig_desc = "commit description";
>  			my $description = "";
>  
> +			$stable = 1 if ($line =~ /\bcommit\s+[0-9a-f]{40}\s+upstream\./i);

If these are really scripted, the case-insensitive /i
shouldn't be necessary.