From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sohny Thomas <sohnythomas@zoho.com>,
gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com, sumit.semwal@linaro.org,
carlos@cgarcia.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef issue
Date: Wed, 01 Jul 2015 08:08:05 -0700 [thread overview]
Message-ID: <1435763285.12101.100.camel@perches.com> (raw)
In-Reply-To: <20150701143132.GZ28762@mwanda>
On Wed, 2015-07-01 at 17:31 +0300, Dan Carpenter wrote:
> On Wed, Jul 01, 2015 at 07:17:58PM +0530, Sohny Thomas wrote:
> >
> > As per checkpatch.pl remove unnecessary typedef
> > Here ion_user_handle_t was used only in the header .
> >
> > Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
>
> The original code was correct.
because the typedef is exposed to user-space. (uapi)
> Checkpatch.pl is not the king of the
> world, which you must obey or die.
As Dan once said, "it's less sentient than a squirrel".
> It is just a perl script.
Don't be a squirrel.
Please engage your brain when using the stupid little tool.
prev parent reply other threads:[~2015-07-01 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5593EDBF.6010008@zoho.com>
2015-07-01 13:47 ` [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef issue Sohny Thomas
2015-07-01 14:21 ` Frans Klaver
2015-07-01 14:31 ` Dan Carpenter
2015-07-01 15:08 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435763285.12101.100.camel@perches.com \
--to=joe@perches.com \
--cc=arve@android.com \
--cc=carlos@cgarcia.org \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sohnythomas@zoho.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox