From: James Liao <jamesjj.liao@mediatek.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
Ricky Liang <jcliang@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: Re: [PATCH v2 1/4] clk: mediatek: mt8173: Fix enabling of critical clocks
Date: Thu, 2 Jul 2015 10:18:09 +0800 [thread overview]
Message-ID: <1435803489.3526.18.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omDqSEn_WnUYz0XmeRpejhthb0J_qa4H9VEfihtA0Axorg@mail.gmail.com>
Hi Daniel,
On Wed, 2015-07-01 at 22:21 +0800, Daniel Kurtz wrote:
> To be precise, it is the CLK_TOP clocks that have CLK_APMIXED PLLs as
> their parents, so we cannot enable the CLK_TOP critical clocks until
> the CLK_APMIXED clocks have all been registered.
>
> Please add something like the above to the commit message.
OK. I'll add them.
>
> >
> > +static struct clk_onecell_data *mt8173_top_clk_data;
> > +static struct clk_onecell_data *mt8173_pll_clk_data;
>
> These globals can be:
> __initdata
>
> > +
> > +static void mtk_clk_enable_critical(void)
>
> And this function is:
>
> static void __init
I'll add them in next patch.
Best regards,
James
next prev parent reply other threads:[~2015-07-02 2:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 2:58 [PATCH v2 0/4] Add Mediatek MT8173 subsystem clocks support James Liao
2015-06-30 2:58 ` [PATCH v2 1/4] clk: mediatek: mt8173: Fix enabling of critical clocks James Liao
2015-07-01 14:21 ` Daniel Kurtz
2015-07-02 2:07 ` Daniel Kurtz
2015-07-02 2:18 ` James Liao [this message]
2015-07-02 23:03 ` Stephen Boyd
2015-07-03 6:29 ` Daniel Kurtz
2015-07-06 22:52 ` Stephen Boyd
2015-06-30 2:58 ` [PATCH v2 2/4] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao
2015-07-01 13:47 ` Daniel Kurtz
2015-07-02 2:52 ` James Liao
2015-07-02 4:26 ` Daniel Kurtz
2015-07-02 23:40 ` Stephen Boyd
2015-07-03 10:46 ` Daniel Kurtz
2015-07-07 6:56 ` James Liao
2015-07-01 16:03 ` Rob Herring
2015-06-30 2:58 ` [PATCH v2 3/4] clk: mediatek: Add subsystem clocks of MT8173 James Liao
2015-07-01 14:54 ` Daniel Kurtz
2015-07-03 5:15 ` James Liao
2015-07-03 6:08 ` Daniel Kurtz
2015-06-30 2:58 ` [PATCH v2 4/4] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao
[not found] ` <CAGS+omBRAJVN3uPYn9YdKZ3VBj61c-rpY_cNgnK6x9U0uJBPYw@mail.gmail.com>
2015-07-01 15:22 ` Daniel Kurtz
2015-07-03 5:38 ` James Liao
2015-07-03 6:28 ` Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435803489.3526.18.camel@mtksdaap41 \
--to=jamesjj.liao@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=jcliang@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox