From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750958AbbGBGUg (ORCPT ); Thu, 2 Jul 2015 02:20:36 -0400 Received: from smtprelay0005.hostedemail.com ([216.40.44.5]:47379 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753151AbbGBGU3 (ORCPT ); Thu, 2 Jul 2015 02:20:29 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:152:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:4250:4321:5007:6119:6261:6691:7514:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12517:12519:12740:13069:13311:13357:13894:21080:21212,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: brass90_40da4743d40d X-Filterd-Recvd-Size: 2402 Message-ID: <1435818026.2487.5.camel@perches.com> Subject: Re: [PATCH] defines modified to match the 80-char rule From: Joe Perches To: Krzysztof =?UTF-8?Q?Ha=C5=82asa?= , Mario Bambagini Cc: linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Date: Wed, 01 Jul 2015 23:20:26 -0700 In-Reply-To: References: <1435094481-32275-1-git-send-email-mario.bambagini@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-07-01 at 09:59 +0200, Krzysztof Hałasa wrote: > Mario Bambagini writes: > > > Defines have been written in more than one line to match the 80-character > > rule. This error has been fixed 6 times in this file. > > The file is fully compliant with respect to the coding rules now. > > Rules, maybe. But is it better, i.e., more readable? > > > --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h > > +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h [] > > -#define LCONSOLE(mask, format, ...) CDEBUG(D_CONSOLE | (mask), format, ## __VA_ARGS__) [] > > +#define LCONSOLE(mask, format, ...) \ > > + CDEBUG(D_CONSOLE | (mask), format, ## __VA_ARGS__) > ... I don't think so. Perhaps if I wasn't using the bleading edge tech > 132-column digital flat LCD screen, I would see this differently (Emacs > isn't perfect when displaying long lines on IBM monochrome display > adapter, even with the intelligent-long-lines-wrap package). I think this isn't particularly nice because of the different alignment styles used for the macros. I think it's OK as is, but it _might_ be nicer if it removed the space after ## and used the same indent as most other macros. #define LCONSOLE(mask, fmt, ...) \ CDEBUG(D_CONSOLE | (mask), fmt, ##__VA_ARGS__) and #define LCONSOLE_ERROR_MSG(errnum, fmt, ...) \ CDEBUG_LIMIT(D_CONSOLE | D_ERROR, "%x-%x: " fmt, \ errnum, LERRCHKSUM(errnum), ##__VA_ARGS__)