public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	daniel@zonque.org, tixxdz@opendz.org,
	David Herrmann <dh.herrmann@gmail.com>
Subject: [PATCH 6/6] kdbus: fix NULL-deref in activator cleanup
Date: Thu,  2 Jul 2015 10:28:34 +0200	[thread overview]
Message-ID: <1435825714-3567-7-git-send-email-dh.herrmann@gmail.com> (raw)
In-Reply-To: <1435825714-3567-1-git-send-email-dh.herrmann@gmail.com>

Right now, we always assume an activator has a valid name and
conn->activator_of is set. However, this assumption is not true if the
setup of the activator fails. In those cases, the ->flags field indicates
an activator, but the name might not have been claimed, yet.

Fix the destructor of connections to not assume all activators have
claimed names.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
 ipc/kdbus/names.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipc/kdbus/names.c b/ipc/kdbus/names.c
index d77ee08..057f806 100644
--- a/ipc/kdbus/names.c
+++ b/ipc/kdbus/names.c
@@ -444,7 +444,7 @@ void kdbus_name_release_all(struct kdbus_name_registry *reg,
 
 	down_write(&reg->rwlock);
 
-	if (kdbus_conn_is_activator(conn)) {
+	if (conn->activator_of) {
 		activator = conn->activator_of->activator;
 		conn->activator_of->activator = NULL;
 	}
-- 
2.4.5


  parent reply	other threads:[~2015-07-02  8:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02  8:28 [PATCH 0/6] Miscellaneous kdbus fixes and code removal David Herrmann
2015-07-02  8:28 ` [PATCH 1/6] kdbus/selftests: fix CAP translation tests David Herrmann
2015-07-02  8:28 ` [PATCH 2/6] kdbus: drop redundant KDBUS_MSG_MAX_ITEMS David Herrmann
2015-07-03 21:14   ` Sergei Zviagintsev
2015-07-04 11:22   ` [PATCH v2 " David Herrmann
2015-07-02  8:28 ` [PATCH 3/6] kdbus: drop unused 'bloom_generation' field David Herrmann
2015-07-02  8:28 ` [PATCH 4/6] kdbus: drop support for required attach-flags on buses David Herrmann
2015-07-02  8:28 ` [PATCH 5/6] kdbus: pin namespaces on HELLO David Herrmann
2015-07-03 21:44   ` Sergei Zviagintsev
2015-07-04 11:26     ` David Herrmann
2015-07-02  8:28 ` David Herrmann [this message]
2015-07-06 18:49 ` [PATCH 0/6] Miscellaneous kdbus fixes and code removal David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435825714-3567-7-git-send-email-dh.herrmann@gmail.com \
    --to=dh.herrmann@gmail.com \
    --cc=daniel@zonque.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tixxdz@opendz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox