Re: [PATCH 1/3] video/logo: use list of logos to find logo

Geert Uytterhoeven
2015-07-03T09:14:02Z

On Fri, Jul 3, 2015 at 10:38 AM, Urs Fässler <urs.fassler@bytesatwork.ch> wrote:
> -#ifdef CONFIG_LOGO_MAC_CLUT224
> - /* Macintosh Linux logo on m68k */
> - if (MACH_IS_MAC)
> - logo = &logo_mac_clut224;
> +#if defined(CONFIG_LOGO_MAC_CLUT224) && MACH_IS_MAC
> + /* Macintosh Linux logo on m68k */
> + &logo_mac_clut224,
> #endif

That won't work, as depending on kernel configuration, MACH_IS_MAC
can be a run-time test, cfr.

arch/m68k/include/asm/setup.h:# define MACH_IS_MAC (0)
arch/m68k/include/asm/setup.h:# define MACH_IS_MAC (m68k_machtype == MACH_MAC)
arch/m68k/include/asm/setup.h:# define MACH_IS_MAC (1)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds