From: Paul Bolle <pebolle@tiscali.nl>
To: Espen Carlsen <ec@numascale.com>, Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel J Blueman <daniel@numascale.com>,
Steffen Persvold <sp@numascale.com>
Subject: Re: [PATCH, resend] build: fix broken kernel RPM source symlink
Date: Sat, 04 Jul 2015 12:19:29 +0200 [thread overview]
Message-ID: <1436005169.20057.60.camel@tiscali.nl> (raw)
In-Reply-To: <1435664842-17908-1-git-send-email-ec@numascale.com>
On di, 2015-06-30 at 13:47 +0200, Espen Carlsen wrote:
> Fix the 'rpm-pkg' makefile target to always generate the correct
> /usr/src/kernel/<ver> symlink; this fails on non-RPM-native systems
/kernels/
> eg Ubuntu.
>
> On a non-RPM-native system, the symlink created by rpmbuild points to
> the source tree, so the ln -sf commands to overwrite build and source
> will
> create a new link inside the directory pointed to by the build and
> source
> symlinks. This will break the -devel.rpm, as the build and source
> symlinks
> will point to non existing directories after installing them.
Perhaps this is all obvious but what exactly happens currently and what
happens after this change? (An example might help readers that are just
as easily confused as I am. Perhaps that might also explain why this is
only an issue on non-RPM-native systems.)
It doesn't help that the description of -T in "man ln" is rather
unhelpful. "info ln" was better, after following some references, but
I'm still not sure what it buys you for this issue.
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec
> -echo "ln -sf /usr/src/kernels/$KERNELRELEASE build"
> -echo "ln -sf /usr/src/kernels/$KERNELRELEASE source"
> +echo "ln -sfT /usr/src/kernels/$KERNELRELEASE build"
> +echo "ln -sfT /usr/src/kernels/$KERNELRELEASE source"
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-07-05 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 11:47 [PATCH, resend] build: fix broken kernel RPM source symlink Espen Carlsen
2015-07-04 10:19 ` Paul Bolle [this message]
2015-07-06 19:37 ` Espen Carlsen
2015-07-08 14:26 ` Paul Bolle
2015-07-08 15:42 ` Espen Carlsen
2015-07-08 16:18 ` Paul Bolle
2015-07-08 18:47 ` Espen Carlsen
2015-07-08 18:52 ` Paul Bolle
2015-07-08 16:56 ` Paul Bolle
2015-07-09 9:29 ` Espen Carlsen
2015-08-19 15:14 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436005169.20057.60.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=daniel@numascale.com \
--cc=ec@numascale.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sp@numascale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox