d72da4a4 "rbtree: Make lockless searches non-fatal" breaks tools/perf build

d72da4a4 "rbtree: Make lockless searches non-fatal" breaks tools/perf build

[Mike Galbraith]

Hi Peter,

FYI, seems you somehow pissed off the include hell gods.

  CC       builtin-help.o
In file included from /usr/local/src/kernel/linux-3.x.git/include/uapi/linux/kernel.h:4:0,
                 from /usr/local/src/kernel/linux-3.x.git/include/linux/cache.h:4,
                 from /usr/local/src/kernel/linux-3.x.git/include/linux/rcupdate.h:37,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/../../../../include/linux/rbtree.h:34,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/linux/rbtree.h:4,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/../map.h:7,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/../event.h:8,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/../evlist.h:9,
                 from ui/gtk/browser.c:1:
/usr/local/src/kernel/linux-3.x.git/include/uapi/linux/sysinfo.h:8:2: error: unknown type name ‘__kernel_long_t’
  __kernel_long_t uptime;  /* Seconds since boot */
  ^
/usr/local/src/kernel/linux-3.x.git/include/uapi/linux/sysinfo.h:9:2: error: unknown type name ‘__kernel_ulong_t’
  __kernel_ulong_t loads[3]; /* 1, 5, and 15 minute load averages */
  ^
/usr/local/src/kernel/linux-3.x.git/include/uapi/linux/sysinfo.h:10:2: error: unknown type name ‘__kernel_ulong_t’
  __kernel_ulong_t totalram; /* Total usable main memory size */

...

/usr/local/src/kernel/linux-3.x.git/include/uapi/linux/sysinfo.h:21:22: error: ‘__kernel_ulong_t’ undeclared here (not in a function)
  char _f[20-2*sizeof(__kernel_ulong_t)-sizeof(__u32)]; /* Padding: libc5 uses this.. */
                      ^
In file included from /usr/local/src/kernel/linux-3.x.git/arch/x86/include/asm/preempt.h:5:0,
                 from /usr/local/src/kernel/linux-3.x.git/include/linux/preempt.h:64,
                 from /usr/local/src/kernel/linux-3.x.git/include/linux/spinlock.h:50,
                 from /usr/local/src/kernel/linux-3.x.git/include/linux/rcupdate.h:38,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/../../../../include/linux/rbtree.h:34,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/linux/rbtree.h:4,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/../map.h:7,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/../event.h:8,
                 from /usr/local/src/kernel/linux-3.x.git/tools/perf/util/include/../evlist.h:9,
                 from ui/gtk/browser.c:1:
/usr/local/src/kernel/linux-3.x.git/arch/x86/include/asm/percpu.h:521:54: error: expected ‘;’, ‘,’ or ‘)’ before ‘*’ token
                         const unsigned long __percpu *addr)

...

/usr/local/src/kernel/linux-3.x.git/include/linux/percpu-defs.h: In function ‘__this_cpu_preempt_check’:
/usr/local/src/kernel/linux-3.x.git/include/linux/percpu-defs.h:300:57: error: unused parameter ‘op’ [-Werror=unused-parameter]
 static inline void __this_cpu_preempt_check(const char *op) { }
                                                         ^
/usr/local/src/kernel/linux-3.x.git/arch/x86/include/asm/percpu.h: At top level:
/usr/local/src/kernel/linux-3.x.git/include/linux/percpu-defs.h:49:2: error: type defaults to ‘int’ in declaration of ‘__percpu’ [-Werror]
  __percpu __attribute__((section(PER_CPU_BASE_SECTION sec))) \
  ^
/usr/local/src/kernel/linux-3.x.git/include/linux/percpu-defs.h:101:9: note: in expansion of macro ‘__PCPU_ATTRS’
  extern __PCPU_ATTRS(sec) __typeof__(type) name
         ^
/usr/local/src/kernel/linux-3.x.git/include/linux/percpu-defs.h:170:2: note: in expansion of macro ‘DECLARE_PER_CPU_SECTION’
  DECLARE_PER_CPU_SECTION(type, name, "..read_mostly")
  ^
/usr/local/src/kernel/linux-3.x.git/arch/x86/include/asm/percpu.h:554:1: note: in expansion of macro ‘DECLARE_PER_CPU_READ_MOSTLY’
 DECLARE_PER_CPU_READ_MOSTLY(unsigned long, this_cpu_off);
 ^
/usr/local/src/kernel/linux-3.x.git/include/linux/percpu-defs.h:101:27: error: expected ‘,’ or ‘;’ before ‘__typeof__’
  extern __PCPU_ATTRS(sec) __typeof__(type) name
                           ^
/usr/local/src/kernel/linux-3.x.git/include/linux/percpu-defs.h:170:2: note: in expansion of macro ‘DECLARE_PER_CPU_SECTION’
  DECLARE_PER_CPU_SECTION(type, name, "..read_mostly")
  ^
/usr/local/src/kernel/linux-3.x.git/arch/x86/include/asm/percpu.h:554:1: note: in expansion of macro ‘DECLARE_PER_CPU_READ_MOSTLY’
 DECLARE_PER_CPU_READ_MOSTLY(unsigned long, this_cpu_off);

Re: d72da4a4 "rbtree: Make lockless searches non-fatal" breaks tools/perf build

[Peter Zijlstra]

On Sun, Jul 05, 2015 at 02:21:56PM +0200, Mike Galbraith wrote:
> Hi Peter,
> 
> FYI, seems you somehow pissed off the include hell gods.

Yep, there's patch out-there that fix it.

  lkml.kernel.org/r/20150704162422.GE3976@kernel.org

But if you read that thread, you'll find that Linus requested we copy
the rbtree code and I've not yet seen the patches doing that -- but I've
not yet processed the full inbox yet.