From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754268AbbGFJKQ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jul 2015 05:10:16 -0400
Received: from mga11.intel.com ([192.55.52.93]:42361 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753725AbbGFJKJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jul 2015 05:10:09 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,414,1432623600"; 
   d="scan'208";a="723553648"
Message-ID: <1436173803.8279.1.camel@linux.intel.com>
Subject: Re: [PATCH v4 6/8] mfd: make mfd_remove_devices() iterate in
 reverse order
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-acpi@vger.kernel.org,
        linux-pm@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Vinod Koul <vinod.koul@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Mike Turquette <mturquette@linaro.org>
Date: Mon, 06 Jul 2015 12:10:03 +0300
In-Reply-To: <20150624113144.GL15013@x1>
References: <1434362256-239992-1-git-send-email-andriy.shevchenko@linux.intel.com>
	 <1434362256-239992-7-git-send-email-andriy.shevchenko@linux.intel.com>
	 <20150624113144.GL15013@x1>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.3-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-06-24 at 12:31 +0100, Lee Jones wrote:
> On Mon, 15 Jun 2015, Andy Shevchenko wrote:
> 
> > The newly introduced device_for_each_child_reverse() would be used 
> > when MFD
> > core removes the device.
> > 
> > After this patch applied the devices will be removed in a reversed 
> > order. This
> > behaviour is useful when devices have implicit dependency on order, 
> > i.e.
> > consider MFD device with serial bus controller, such as SPI, and 
> > DMA IP that is
> > attached to serial bus controller: before remove the DMA driver we 
> > have to be
> > ensured that no DMA transfers is ongoing and the requested channel 
> > are unused.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/mfd/mfd-core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks.

Hmm… Seems kinda mistake. I can't see this applied (and required
previous patches 4 and 5) to any of your branch neither in (today's)
linux-next.

> 
> > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> > index 1aed3b7..79eeaa5 100644
> > --- a/drivers/mfd/mfd-core.c
> > +++ b/drivers/mfd/mfd-core.c
> > @@ -300,7 +300,7 @@ void mfd_remove_devices(struct device *parent)
> >  {
> >  	atomic_t *cnts = NULL;
> >  
> > -	device_for_each_child(parent, &cnts, 
> > mfd_remove_devices_fn);
> > +	device_for_each_child_reverse(parent, &cnts, 
> > mfd_remove_devices_fn);
> >  	kfree(cnts);
> >  }
> >  EXPORT_SYMBOL(mfd_remove_devices);
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy