Re: [PATCH 15/20] staging/lustre/libcfs: get rid of debugfs/lnet/console_backoff

Dan Carpenter
2015-07-08T08:32:32Z

On Mon, Jul 06, 2015 at 12:48:53PM -0400, green@linuxhacker.ru wrote:
> +static int param_set_uint_minmax(const char *val,
> + const struct kernel_param *kp,
> + unsigned int min, unsigned int max)
> +{
> + unsigned int num;
> + int ret;
> +
> + if (!val)
> + return -EINVAL;
> + ret = kstrtouint(val, 0, &num);
> + if (ret == -EINVAL || num < min || num > max)
^^^
Smatch is smart enough to know that "num" can be uninitialized here on
some paths. It doesn't generate a warning yet because a lot of the
kernel has error paths where we mostly assume things won't fail.

It should probably be:

ret = kstrtouint(val, 0, &num);
if (ret)
return ret;
if (num < min || num > max)
return -EINVAL;

> + return -EINVAL;
> + *((unsigned int *)kp->arg) = num;
> + return 0;
> +}

regards,
dan carpenter