From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbbGGFBX (ORCPT ); Tue, 7 Jul 2015 01:01:23 -0400 Received: from smtprelay0053.hostedemail.com ([216.40.44.53]:35248 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751391AbbGGFBP (ORCPT ); Tue, 7 Jul 2015 01:01:15 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:3870:3871:3872:3873:4250:4321:5007:6261:10004:10400:10848:11026:11232:11657:11658:11914:12043:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bag41_27c1b9ec4aa3b X-Filterd-Recvd-Size: 1805 Message-ID: <1436245271.2682.32.camel@perches.com> Subject: Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c From: Joe Perches To: Greg KH Cc: Vasiliy Korchagin , oleg.drokin@intel.com, devel@driverdev.osuosl.org, andreas.dilger@intel.com, linux-kernel@vger.kernel.org Date: Mon, 06 Jul 2015 22:01:11 -0700 In-Reply-To: <20150707023652.GA9748@kroah.com> References: <1435380784.9377.69.camel@perches.com> <1435383365-25679-1-git-send-email-vasiliy.korchagin@gmail.com> <1435385089.9377.72.camel@perches.com> <20150707023652.GA9748@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-07-06 at 19:36 -0700, Greg KH wrote: > On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote: > > On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote: [] > > > Here is another version with macro expansion. Inline function expansion doesn't > > > seem like a good idea to me as it would make things overcomplicated. > > > > It looks like it'd be simpler to use vsprintf extension %pU [] > > diff --git a/drivers/staging/lustre/lustre/obdclass/uuid.c b/drivers/staging/lustre/lustre/obdclass/uuid.c [] > > + sprintf(out->uuid, "%pU", uu); > > } > > EXPORT_SYMBOL(class_uuid_unparse); > > I agree, much better, can you resend this in a form I can apply? Vasiliy, you started this, can you submit this under your name please?