From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758229AbbGGRF5 (ORCPT ); Tue, 7 Jul 2015 13:05:57 -0400 Received: from mga01.intel.com ([192.55.52.88]:15596 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758206AbbGGRFs (ORCPT ); Tue, 7 Jul 2015 13:05:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,424,1432623600"; d="scan'208";a="724444106" From: Andy Shevchenko To: Alexander Viro , linux-kernel@vger.kernel.org, Joe Perches , Andrew Morton , Tadeusz Struk , Helge Deller , Ingo Tuchscherer , Catalin Marinas , Vladimir Kondratiev Cc: Andy Shevchenko Subject: [PATCH v5 4/6] [S390] zcrypt: use seq_hex_dump() to dump buffers Date: Tue, 7 Jul 2015 20:04:50 +0300 Message-Id: <1436288692-18445-5-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436288692-18445-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1436288692-18445-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of custom approach let's use recently introduced seq_hex_dump() helper. Acked-by: Ingo Tuchscherer Signed-off-by: Andy Shevchenko --- drivers/s390/crypto/zcrypt_api.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index 01bf1f5..4eb4554 100644 --- a/drivers/s390/crypto/zcrypt_api.c +++ b/drivers/s390/crypto/zcrypt_api.c @@ -1206,16 +1206,8 @@ static void sprinthx(unsigned char *title, struct seq_file *m, static void sprinthx4(unsigned char *title, struct seq_file *m, unsigned int *array, unsigned int len) { - int r; - seq_printf(m, "\n%s\n", title); - for (r = 0; r < len; r++) { - if ((r % 8) == 0) - seq_printf(m, " "); - seq_printf(m, "%08X ", array[r]); - if ((r % 8) == 7) - seq_putc(m, '\n'); - } + seq_hex_dump(m, " ", DUMP_PREFIX_NONE, 32, 4, array, len, false); seq_putc(m, '\n'); } -- 2.1.4