From: Joe Perches <joe@perches.com>
To: Valdis.Kletnieks@vt.edu
Cc: Sreenath Madasu <sreenath.madasu@gmail.com>,
jteki@openedev.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c
Date: Tue, 07 Jul 2015 13:38:47 -0700 [thread overview]
Message-ID: <1436301527.2682.60.camel@perches.com> (raw)
In-Reply-To: <15662.1436297570@turing-police.cc.vt.edu>
On Tue, 2015-07-07 at 15:32 -0400, Valdis.Kletnieks@vt.edu wrote:
> All: Is it time to kill that checkpatch test, or hide it behind a non-default
> flag, to prevent code churn?
<shrug> I'm not an 80 column zealot.
This is for staging isn't it?
Code churn there is expected and somewhat desired.
A lot of time, code churn can be useful when it
reduces the indentation depth.
For instance, this code could use continue more.
The longest line in this file is 158 chars, that's
probably excessive, awk shows 35 lines > 80 chars.
staging rtl files have a couple hundred lines > 132
and thousands of lines > 80.
next prev parent reply other threads:[~2015-07-07 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 1:53 [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c Sreenath Madasu
2015-07-07 4:04 ` Greg KH
2015-07-07 19:32 ` Valdis.Kletnieks
2015-07-07 20:38 ` Joe Perches [this message]
2015-07-08 2:08 ` Valdis.Kletnieks
2015-07-08 2:53 ` Joe Perches
2015-07-08 1:08 ` Sreenath Madasu
2015-07-08 2:06 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436301527.2682.60.camel@perches.com \
--to=joe@perches.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=devel@driverdev.osuosl.org \
--cc=jteki@openedev.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sreenath.madasu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox