From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934205AbbGHJdG (ORCPT ); Wed, 8 Jul 2015 05:33:06 -0400 Received: from mga14.intel.com ([192.55.52.115]:58716 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933113AbbGHJc5 (ORCPT ); Wed, 8 Jul 2015 05:32:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,431,1432623600"; d="scan'208";a="520714716" From: Andy Shevchenko To: "David E. Box" , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar Cc: Andy Shevchenko Subject: [PATCH v1 2/4] iosf_mbi: pci_dev_put() is NULL-proof Date: Wed, 8 Jul 2015 12:32:51 +0300 Message-Id: <1436347973-50436-3-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436347973-50436-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1436347973-50436-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No need to check for NULL when call pci_dev_put(). Signed-off-by: Andy Shevchenko --- arch/x86/kernel/iosf_mbi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c index 2362da9..0b33105 100644 --- a/arch/x86/kernel/iosf_mbi.c +++ b/arch/x86/kernel/iosf_mbi.c @@ -314,10 +314,8 @@ static void __exit iosf_mbi_exit(void) iosf_debugfs_remove(); pci_unregister_driver(&iosf_mbi_pci_driver); - if (mbi_pdev) { - pci_dev_put(mbi_pdev); - mbi_pdev = NULL; - } + pci_dev_put(mbi_pdev); + mbi_pdev = NULL; } module_init(iosf_mbi_init); -- 2.1.4