From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933357AbbGHKCz (ORCPT ); Wed, 8 Jul 2015 06:02:55 -0400 Received: from mga01.intel.com ([192.55.52.88]:38044 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932442AbbGHKCx (ORCPT ); Wed, 8 Jul 2015 06:02:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,431,1432623600"; d="scan'208";a="724953634" Message-ID: <1436349642.10819.60.camel@linux.intel.com> Subject: Re: [PATCH v1 0/4] iosf_mbi: clean up From: Andy Shevchenko To: Ingo Molnar Cc: "David E. Box" , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar Date: Wed, 08 Jul 2015 13:00:42 +0300 In-Reply-To: <20150708093641.GA1989@gmail.com> References: <1436347973-50436-1-git-send-email-andriy.shevchenko@linux.intel.com> <20150708093641.GA1989@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-07-08 at 11:36 +0200, Ingo Molnar wrote: > * Andy Shevchenko wrote: > > > There are few patches to clean up (with small fixes) iosf_mbi > > driver along with > > extension it to cover Intel Tangier. > > > > Andy Shevchenko (4): > > iosf_mbi: check result for all calls of debugfs API > > iosf_mbi: pci_dev_put() is NULL-proof > > iosf_mbi: group global variables > > iosf_mbi: append Intel Tangier ID > > > > arch/x86/include/asm/iosf_mbi.h | 8 ++++---- > > arch/x86/kernel/iosf_mbi.c | 31 +++++++++++++++-------------- > > -- > > 2 files changed, 19 insertions(+), 20 deletions(-) > > Could you please also move it from arch/x86/kernel/ to > arch/x86/platform/[intel-quark?] while at it? I will think about proper folder (apparently not quark, since it is specific to man different Intel SoCs). > > arch/x86/kernel/ is the wrong place for this driver. Would be okay to send an additional patch or better to regenerate the whole series? -- Andy Shevchenko Intel Finland Oy