From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933505AbbGHKDD (ORCPT ); Wed, 8 Jul 2015 06:03:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:51074 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933350AbbGHKC4 (ORCPT ); Wed, 8 Jul 2015 06:02:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,431,1432623600"; d="scan'208";a="520724473" Message-ID: <1436349743.10819.62.camel@linux.intel.com> Subject: Re: [PATCH v1 1/4] iosf_mbi: check result for all calls of debugfs API From: Andy Shevchenko To: Thomas Gleixner Cc: "David E. Box" , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar Date: Wed, 08 Jul 2015 13:02:23 +0300 In-Reply-To: References: <1436347973-50436-1-git-send-email-andriy.shevchenko@linux.intel.com> <1436347973-50436-2-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-07-08 at 11:49 +0200, Thomas Gleixner wrote: > On Wed, 8 Jul 2015, Andy Shevchenko wrote: > > > While here, replase IS_ERR_OR_NULL(x) to just !x since first one > does the job > > for us. > > While here? The first one? What? Can you please provide a sensible > changelog? It's a continuation of the subject line. I will amend the commit message. > > Thanks, > > tglx -- Andy Shevchenko Intel Finland Oy