Re: [RESEND 2][PATCH v4] hexdump: fix for non-aligned buffers

Geert Uytterhoeven
2015-07-09T07:16:59Z

On Thu, Jul 9, 2015 at 4:07 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
>> The other alternative in Documentation/unaligned-memory-access.txt is the
>> macro get_unaligned() from asm/unaligned.h. However, using get_unaligned()
>> would mean a much more intrusive patch, since each case of the groupsize
>> would be changed, and anyway we would still need to check
>> CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to avoid penalising everyone.
>
> Actually, I think using get_unaligned() would be a better solution.
> For architectures which have CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y,
> get_unaligned() should be fast - just one instruction.
>
> This way we avoid having different-appearing output on different
> architectures.

Definitely.

A less optimal get_unaligned() will just be noise in the snprintf() processing
time.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds