From: Joe Perches <joe@perches.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Lindent: Handle missing indent gracefully
Date: Fri, 10 Jul 2015 10:04:07 -0700 [thread overview]
Message-ID: <1436547847.24866.50.camel@perches.com> (raw)
In-Reply-To: <1436535395.4540.18.camel@chaos.site>
On Fri, 2015-07-10 at 15:36 +0200, Jean Delvare wrote:
> Hi Joe,
howdy Jean.
> Le Friday 10 July 2015 à 04:51 -0700, Joe Perches a écrit :
> > On Fri, 2015-07-10 at 13:47 +0200, Jean Delvare wrote:
> > > If indent is not found, bail out immediately instead of spitting
> > > random shell script error messages.
> >
> > OK, but can't we just delete Lindent instead?
>
> Because...?
It's just not very useful in today's development space.
indent is quite bad at handling long lines.
It wraps code at arbitrary points to fit a column boundary
rather than for readability or sensibility.
Code that may have deep indentation using a few spaces
per block level can look horrible post Lindent.
For instance, reiserfs commit bd4c625c061c
("reiserfs: run scripts/Lindent on reiserfs code")
There are other tools that reflow whitespace styles.
next prev parent reply other threads:[~2015-07-10 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 11:47 [PATCH] Lindent: Handle missing indent gracefully Jean Delvare
2015-07-10 11:51 ` Joe Perches
2015-07-10 13:36 ` Jean Delvare
2015-07-10 17:04 ` Joe Perches [this message]
2015-07-10 21:37 ` Andrew Morton
2015-07-11 12:56 ` Joe Perches
2015-07-15 21:15 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436547847.24866.50.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox