From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933030AbbGJRET (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jul 2015 13:04:19 -0400
Received: from smtprelay0117.hostedemail.com ([216.40.44.117]:51644 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S932798AbbGJREL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jul 2015 13:04:11 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3866:3867:3870:3871:3872:3874:4321:5007:6261:10004:10400:10848:11232:11658:11914:12050:12517:12519:12740:13069:13161:13229:13311:13357:13894:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: jewel66_7b8a8a2d27f0a
X-Filterd-Recvd-Size: 1749
Message-ID: <1436547847.24866.50.camel@perches.com>
Subject: Re: [PATCH] Lindent: Handle missing indent gracefully
From: Joe Perches <joe@perches.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Date: Fri, 10 Jul 2015 10:04:07 -0700
In-Reply-To: <1436535395.4540.18.camel@chaos.site>
References: <20150710134751.624de706@endymion.delvare>
	 <1436529101.24866.39.camel@perches.com>
	 <1436535395.4540.18.camel@chaos.site>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-07-10 at 15:36 +0200, Jean Delvare wrote:
> Hi Joe,

howdy Jean.

> Le Friday 10 July 2015 à 04:51 -0700, Joe Perches a écrit :
> > On Fri, 2015-07-10 at 13:47 +0200, Jean Delvare wrote:
> > > If indent is not found, bail out immediately instead of spitting
> > > random shell script error messages.
> > 
> > OK, but can't we just delete Lindent instead?
> 
> Because...?

It's just not very useful in today's development space.

indent is quite bad at handling long lines.

It wraps code at arbitrary points to fit a column boundary
rather than for readability or sensibility.

Code that may have deep indentation using a few spaces
per block level can look horrible post Lindent.

For instance, reiserfs commit bd4c625c061c
("reiserfs: run scripts/Lindent on reiserfs code")

There are other tools that reflow whitespace styles.