From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751064AbbGKM4l (ORCPT ); Sat, 11 Jul 2015 08:56:41 -0400 Received: from smtprelay0192.hostedemail.com ([216.40.44.192]:54505 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750701AbbGKM4k (ORCPT ); Sat, 11 Jul 2015 08:56:40 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:967:973:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2551:2553:2565:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3770:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4659:5007:6117:6261:6691:7903:8599:8957:8985:9025:9388:10004:10400:10848:10967:11027:11232:11257:11658:11914:12043:12050:12438:12517:12519:12682:12740:12776:13069:13160:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: magic00_39ed61270d732 X-Filterd-Recvd-Size: 2597 Message-ID: <1436619397.2711.19.camel@perches.com> Subject: Re: [PATCH] Lindent: Handle missing indent gracefully From: Joe Perches To: Andrew Morton Cc: Jean Delvare , LKML Date: Sat, 11 Jul 2015 05:56:37 -0700 In-Reply-To: <20150710143732.108f19c660402c8dedc18263@linux-foundation.org> References: <20150710134751.624de706@endymion.delvare> <1436529101.24866.39.camel@perches.com> <1436535395.4540.18.camel@chaos.site> <1436547847.24866.50.camel@perches.com> <20150710143732.108f19c660402c8dedc18263@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-07-10 at 14:37 -0700, Andrew Morton wrote: > On Fri, 10 Jul 2015 10:04:07 -0700 Joe Perches wrote: > > > > Le Friday 10 July 2015 __ 04:51 -0700, Joe Perches a __crit : > > > > On Fri, 2015-07-10 at 13:47 +0200, Jean Delvare wrote: > > > > > If indent is not found, bail out immediately instead of spitting > > > > > random shell script error messages. > > > > > > > > OK, but can't we just delete Lindent instead? > > > > > > Because...? > > > > It's just not very useful in today's development space. > > I've very occasionally used Lindent. It's useful if the input is an > utter mess. You feed it through Lindent as a first pass then get in and > do the remainder by hand. > > It can be less work than doing the whole conversion by hand. That's true, it can be, but I think Lindent mostly doesn't work particularly well for reviewing and it can require a lot more rework. My biggest complaint about Lindent is that it can produce _awful_ looking code when it has to wrap longish lines. I think that generally, checkpatch --fix-inplace works better and it can work in discrete steps. I submitted a little script a while back that does most of what Lindent does. https://lkml.org/lkml/2014/7/11/794 uncrustify also kinda works without the line wrapping nuttiness. It's not very good about using Linux's pointer location style. http://uncrustify.sourceforge.net/ clang-format works reasonably well. It can respect existing line wrapping. http://clang.llvm.org/docs/ClangFormatStyleOptions.html