Re: [PATCH v2 10/13] pinctrl: kill off set_irq_flags usage

Tomasz Figa
2015-07-12T15:46:01Z

Hi,

2015-07-12 23:26 GMT+09:00 Rob Herring <robh@kernel.org>:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Thomas Abraham <thomas.abraham@linaro.org>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-rpi-kernel@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> ---
> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 1 -
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 --
> drivers/pinctrl/pinctrl-single.c | 5 -----
> drivers/pinctrl/samsung/pinctrl-exynos.c | 1 -
> drivers/pinctrl/samsung/pinctrl-exynos5440.c | 1 -
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 2 --
> drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 2 --

For drivers/pinctrl/samsung:

Acked-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz