Re: [PATCH 09/10] blkcg: move io_service_bytes and io_serviced stats into blkcg_gq

Tejun Heo
2015-07-15T16:53:30Z

Hello, Vivek.

On Wed, Jul 15, 2015 at 12:29:52PM -0400, Vivek Goyal wrote:
> Ok. I am personally little apprehensive of changing the meaning of
> current stat, but I can live with it.

Sure, if there are use cases which actually get impacted by this,
reverting the original stats shouldn't be difficult. I don't think
it's likely to matter tho. I mean, we even get sync / async
distinction completely wrong in these stats. We're really pumping out
garbage.

> Can you please also update the blkio-controller.txt to reflect these
> changes. I think following sections would require updation.
>
> blkio.throttle.io_serviced
> blkio.throttle.io_service_bytes
>
> And we could mention in blkio.io_serviced that accounting is terms of
> numeber of bios.

Sure thing.

Thanks.

--
tejun