public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Wang <nwang@suse.com>
To: nwang@suse.com
Cc: philipp.reisner@linbit.com,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: [Patch v2 01/10] drbd: Fix the wrong logic of moving history
Date: Mon, 13 Jul 2015 16:38:55 +0800	[thread overview]
Message-ID: <1436776744-3135-2-git-send-email-nwang@suse.com> (raw)
In-Reply-To: <1436776744-3135-1-git-send-email-nwang@suse.com>

Logic of moving history is wrong. May overlap
history when more than two history.
If won't extent more that two history. The loop
can be delete.

Signed-off-by: Nick Wang <nwang@suse.com>
CC: Philipp Reisner <philipp.reisner@linbit.com>
CC: Lars Ellenberg <lars.ellenberg@linbit.com>
CC: drbd-dev@lists.linbit.com
CC: linux-kernel@vger.kernel.org
---
 drbd/drbd_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drbd/drbd_main.c b/drbd/drbd_main.c
index 9871894..a3dc39e 100644
--- a/drbd/drbd_main.c
+++ b/drbd/drbd_main.c
@@ -3466,8 +3466,8 @@ void drbd_uuid_move_history(struct drbd_device *device) __must_hold(local)
 {
 	int i;
 
-	for (i = UI_HISTORY_START; i < UI_HISTORY_END; i++)
-		device->ldev->md.uuid[i+1] = device->ldev->md.uuid[i];
+	for (i = UI_HISTORY_END; i > UI_HISTORY_START; i--)
+		device->ldev->md.uuid[i] = device->ldev->md.uuid[i-1];
 }
 
 void __drbd_uuid_set(struct drbd_device *device, int idx, u64 val) __must_hold(local)
-- 
1.8.4.5


  reply	other threads:[~2015-07-13  8:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  8:38 [Patch v2 00/10] Zero out devices instead of initial full sync Nick Wang
2015-07-13  8:38 ` Nick Wang [this message]
2015-07-13  8:38 ` [Patch v2 02/10] drbd: Add option zap_devices to new-current-uuid Nick Wang
2015-07-31 12:50   ` [Drbd-dev] " Philipp Reisner
2015-07-13  8:38 ` [Patch v2 03/10] drbd: A function to zero out drbd backing device Nick Wang
2015-07-13  8:38 ` [Patch v2 04/10] drbd: New packet P_ZERO_OUT Nick Wang
2015-07-13  8:38 ` [Patch v2 05/10] drbd: Functions to notify peer node to zero out Nick Wang
2015-07-13  8:39 ` [Patch v2 06/10] drbd: Wapper for zeroing out device by worker Nick Wang
2015-07-13  8:39 ` [Patch v2 07/10] drbd: Flags for background drbd device work Nick Wang
2015-07-13  8:39 ` [Patch v2 08/10] drbd: Function to work with packet P_ZERO_OUT Nick Wang
2015-07-13  8:39 ` [Patch v2 09/10] drbd: Handle zero out command from peer node Nick Wang
2015-07-13  8:39 ` [Patch v2 10/10] drbd: Handle new-current-uuid --zap-devices Nick Wang
2015-07-31 12:48 ` [Drbd-dev] [Patch v2 00/10] Zero out devices instead of initial full sync Philipp Reisner
2015-08-06 10:04   ` [PATCH v3 0/1] Zeroout/discard " Nick Wang
2015-08-06 10:04     ` [PATCH] drbd: Support zeroout device " Nick Wang
2015-08-18 15:03       ` Lars Ellenberg
2015-08-21  3:26         ` 答复: " Nick Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436776744-3135-2-git-send-email-nwang@suse.com \
    --to=nwang@suse.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox