From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbbGMLm0 (ORCPT ); Mon, 13 Jul 2015 07:42:26 -0400 Received: from smtprelay0035.hostedemail.com ([216.40.44.35]:49105 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751098AbbGMLmZ (ORCPT ); Mon, 13 Jul 2015 07:42:25 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3350:3622:3870:3876:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:8985:9025:10004:10400:10848:11026:11232:11473:11657:11658:11854:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: show41_6c3294ca86f04 X-Filterd-Recvd-Size: 1715 Message-ID: <1436787742.2711.98.camel@perches.com> Subject: Re: [PATCH] Staging: android: ion: Fix Style Issue From: Joe Perches To: Craig Cc: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, mitchelh@codeaurora.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 13 Jul 2015 04:42:22 -0700 In-Reply-To: <1436808581-14864-1-git-send-email-craig.inches@xayto.net> References: <1436808581-14864-1-git-send-email-craig.inches@xayto.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-07-13 at 17:29 +0000, Craig wrote: > Modified style issue in ion.c. Missing empty line after a definition > > Signed-off-by: Craig > --- > drivers/staging/android/ion/ion.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 6f48112..e44f5e6 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client, > struct ion_buffer *buffer; > struct dma_buf *dmabuf; > bool valid_handle; > + > DEFINE_DMA_BUF_EXPORT_INFO(exp_info); > > mutex_lock(&client->lock); checkpatch false positive. Fixed in checkpatch by https://lkml.org/lkml/2015/7/1/383