From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752964AbbGNCad (ORCPT ); Mon, 13 Jul 2015 22:30:33 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:34593 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931AbbGNCab (ORCPT ); Mon, 13 Jul 2015 22:30:31 -0400 Message-ID: <1436841028.3496.13.camel@gmail.com> Subject: Re: [PATCH v2] sched: let __sched_period() use rq's nr_running From: Mike Galbraith To: Byungchul Park Cc: Morten Rasmussen , mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org Date: Tue, 14 Jul 2015 04:30:28 +0200 In-Reply-To: <20150714020721.GA3956@byungchulpark-X58A-UD3R> References: <1436515890-10792-1-git-send-email-byungchul.park@lge.com> <20150710133107.GC8668@e105550-lin.cambridge.arm.com> <20150713005639.GH31287@byungchulpark-X58A-UD3R> <1436771221.6576.60.camel@gmail.com> <20150713082900.GI31287@byungchulpark-X58A-UD3R> <1436782937.6576.103.camel@gmail.com> <20150713110746.GK31287@byungchulpark-X58A-UD3R> <1436790638.6576.190.camel@gmail.com> <20150714020721.GA3956@byungchulpark-X58A-UD3R> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-07-14 at 11:07 +0900, Byungchul Park wrote: > but.. is there any reason meaningless code should be kept in source? :( > it also harms readability. of cource, i need to modify my patch a little > bit to prevent non-group sched entities from getting large slice. By all means proceed, I'm not trying to discourage you. -Mike