From: Oliver Neukum <oneukum@suse.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: Destroy IDRs on module exit
Date: Tue, 14 Jul 2015 11:17:59 +0200 [thread overview]
Message-ID: <1436865479.22561.2.camel@suse.com> (raw)
In-Reply-To: <1436865374-22027-1-git-send-email-jthumshirn@suse.de>
On Tue, 2015-07-14 at 11:16 +0200, Johannes Thumshirn wrote:
> Destroy IDRs on module exit, freeing the resources for
> * bq2415x_charger.c
> * ds2782_battery.c
> * ltc2941-battery-gauge.c
>
> The drivers had to be converted to "ordinary"
> module_init()/module_exit()
> style drivers instead of using module_i2c_driver.
That is a drawback. How about adding a pointer to the idr
to "struct i2c_driver" and destroy it in generic code?
Regards
Oliver
next prev parent reply other threads:[~2015-07-14 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 9:16 [PATCH] power: Destroy IDRs on module exit Johannes Thumshirn
2015-07-14 9:17 ` Oliver Neukum [this message]
2015-07-14 9:20 ` Pali Rohár
2015-07-14 10:19 ` Sebastian Reichel
2015-07-14 10:48 ` Johannes Thumshirn
2015-07-14 12:14 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436865479.22561.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox