From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751914AbbGOEMC (ORCPT ); Wed, 15 Jul 2015 00:12:02 -0400 Received: from smtprelay0099.hostedemail.com ([216.40.44.99]:49703 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750714AbbGOEMA (ORCPT ); Wed, 15 Jul 2015 00:12:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3874:4321:4434:5007:6261:7903:8957:10004:10400:10848:11026:11232:11473:11658:11914:12438:12517:12519:12555:12679:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: man77_4b77a7d025a25 X-Filterd-Recvd-Size: 2110 Message-ID: <1436933517.16262.13.camel@perches.com> Subject: Re: [patch] checkpatch: Fixes: tag lines are allowed to be long From: Joe Perches To: Dan Carpenter Cc: Andy Whitcroft , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Jes.Sorensen@redhat.com, sparmaintainer@unisys.com, driverdev-devel@linuxdriverproject.org, Tim Sell Date: Tue, 14 Jul 2015 21:11:57 -0700 In-Reply-To: <20150714110736.GA10856@mwanda> References: <20150714110736.GA10856@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-07-14 at 14:07 +0300, Dan Carpenter wrote: > A lot of the Fixes: tags go over the 75 character limit and that's ok. > > Fixes: 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns') > Signed-off-by: Dan Carpenter > --- > The other common cause of false positives it Oops output but I don't > have an idea how to filter for that. > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 90e1edc..537973b 100755[0-9a-f > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2310,7 +2310,7 @@ sub process { > > # Check for line lengths > 75 in commit log, warn once > if ($in_commit_log && !$commit_log_long_line && > - length($line) > 75) { > + length($line) > 75 && !($line =~ /^Fixes:/)) { > WARN("COMMIT_LOG_LONG_LINE", > "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr); > $commit_log_long_line = 1; Maybe some combination of: ^\s*> ^.*\[\s*timestamp\s*\] ^\s*\[\<0-9a-f\>\] oops: BUG: Unable to Unable to Followed by any blank line to reset